Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: https://www.drupal.org/project/drupal/issues/3189805. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Core migration issues:
0️⃣ Who is here today? How is the new year going for you? (edited)
| benjifisher | Benji Fisher, one of the migration system co-maintainers. I live in the US and am a little shaken by yesterday's events. |
| Gábor Hojtsy (he/him) | Gábor Hojtsy, 2021 seems to be kicking off slow here thank god :smile: |
| damienmckenna | Damien McKenna. 2021 is a mixed bag, but thankfully mostly caramels with just a few strawberry cremes :wink: |
| heddn | Lucas. The holidays are finally over... nice to get back to more regular life again with school starting up again. |
| quietone | Vicki. Had a nice time visiting friends and glad to have picked 6kg of blueberries. |
| Matroskeen | Ivan. I live in Ukraine so we’re still celebrating because we use the old ‘Julian’ calendar :thinking_face: |
1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
| Gábor Hojtsy (he/him) | Re-introduce migrate as a community initiative? It is listed as complete on https://www.drupal.org/about/core/strategic-initiatives and not listed on https://www.drupal.org/community-initiatives of course |
| damienmckenna | Drupal 9 compatibility? |
| damienmckenna | Moving all Migrate contrib modules back to d.o issue queues? |
2️⃣ Action items. To be added later.
| benjifisher | RTBC: Drupal 9 compatibility fixes for Commerce Migrate (#3150733: Drupal 9 compatibility fixes for Commerce Migrate). @heddn or @quietone. |
| benjifisher | Invalid migrations being ignored by the migrate process plugin: migration_lookup: decide whether to close #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance and promote that issue to Major. |
| benjifisher | Update Migrate Tools for Drush 10.4 (https://gitlab.com/drupalspoons/migrate_tools/-/issues/118). @benjifisher |
| benjifisher | NR: Add documentation for taxonomy terms source plugins (#3189587: Add documentation for taxonomy terms source plugins) |
| benjifisher | NR: SQL source plugins: allow defining conditions in migration yml (#3069776: SQL source plugins: allow defining conditions and join in migration yml) |
| benjifisher | NW: Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface (#2852463: Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface). @heddn, @mikelutz (he/him) |
| benjifisher | NR: Expose full set of debugging data in migrate_message table (filterable/searchable) (#3063856: Add ability to view migrate_message table data). @benjifisher |
3️⃣ Statistics
| benjifisher | Fixed since the 2020-12-24 meeting: 4 |
| benjifisher | RTBC: 5, including two Major and two that have been waiting more than a month. |
| benjifisher | NR: 34, including 4 Major and one that has not been updated in more than 4 weeks.There are a lot of recently created issues that need review. Some are probably not complicated. Volunteers? |
4️⃣ How can I help? Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...
| quietone | no discussion |
5️⃣ Should we reopen the migration initiative?
| benjifisher | It was originally a strategic initiative, and it was declared completed. Should we reopen it as a community initiative?What would the goals be?What are the advantages of having an initiative, when we already have a team of maintainers? |
| Gábor Hojtsy (he/him) | I think the community initiatives page would MAYBE help drive people to the meetings? |
| benjifisher | ... where they will see my pleas for help with the NR queue and 4️⃣ |
| benjifisher | How does migration compare to other subsystems? Are we unusual in having weekly meetings? |
| heddn | most sub systems do not have weekly meetings. migrate is unique |
| benjifisher | I am willing to give it a try. What is involved in establishing an initiative? What do the other maintainers think? Do we need to specify goals? If so, what are they? |
| Gábor Hojtsy (he/him) | I am by no means suggesting to add more to anyone’s plate :smile: it felt like the meetings carry on the torch from the initiative |
| quietone | I too am willing. I definitely want goals - keep us on track and to know when the initiative is complete. |
6️⃣ Drupal 9 compatibility
| benjifisher | I guess this refers to the non-core migration modules. What is the current status? |
| damienmckenna | Many/most modules appear to be D9 compatible, e.g. migrate_upgrade. |
| damienmckenna | Some are unfinished but close, e.g. #3150733: Drupal 9 compatibility fixes for Commerce Migrate |
| benjifisher | That issue is RTBC. Who are the maintainers of Commerce Migrate? |
| benjifisher | I guess @quietone, @heddn, @mglaman. |
| heddn | Should we spawn a new major version of the module to handle >=9 support? While not strictly necessary, it might make things easier as 9.1 and 8.9 aren't very equal these days. phpunit test divergence is getting more complicated. |
| heddn | and it gets worse when you throw in trying to also support 9.2+ |
| benjifisher | No objection. I am not involved with CM, and you know more about the incompatibilities than I do. |
| heddn | To put in perspective, I recently dropped testing support on 8.9 for some other contrib migrate projects because I don't have the energy to support PHPUnit 7 and PHPUnit 9 at the same time. |
7️⃣ Move contrib modules back to d.o
| benjifisher | Several modules maintained by @heddn are using DrupalSpoons. Now that we have MRs on d.o, it may be time to end that experiment.I support moving back to d.o. |
| damienmckenna | As mentioned before, I really think it'd help the ecosystem if the main Migrate contrib modules were fully available on d.o instead of Spoons. |
| benjifisher | @heddn, please comment. |
| damienmckenna | @heddn: Any response? |
| heddn | I keep wanting to respond, then not. Mainly because I'm afraid that my desire to stay on Spoons will disappoint so many people. When I went down the path of using it, d.o had very limited features in this space. True enough, that has gotten better since then. But there are still a lot of features missing on d.o. If I had to make the decision now about switching, I might have arrived at a different point. But now that I've tasted Spoons, it is hard to go back to d.o. again. I'm not ruling it out. I just haven't been convinced yet to return. |
| damienmckenna | Would you be willing to run both, so we can at least do patches and merge requests on d.o, and be able to more easily search & find things rather than floating off on their own island? |
8️⃣ Two new DOM-based process plugins in Migrate Plus
| benjifisher | These will be available in the next release of Migrate Plus; they are now in the dev release. I am working on a presentation that mentions them. |
| benjifisher | https://gitlab.com/drupalspoons/migrate_plus/-/issues/163https://gitlab.... |
9️⃣ MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance (and related issues)
| benjifisher | #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance |
| benjifisher | More recent issue, marked Major and NR: is this a duplicate? #3143486: Invalid migrations being ignored by the migrate process plugin: migration_lookup |
| benjifisher | There are a couple of other related issues mentioned in the comments. If the newer one is a duplicate, should we close it? Should we promote the older one to Major? |
1️⃣0️⃣ Migrate commands are now part of Drush core
| benjifisher | https://gitlab.com/drupalspoons/migrate_tools/-/issues/118 |
| benjifisher | I think we will need to update Migrate Tools, possibly also Migrate Plus, because of this change. Drush 10.4 will probably be released soon, and it will include the migration commands from Migrate Run, supporting core migrations. |
| benjifisher | I may have time to work on this today and tomorrow. |
1️⃣1️⃣ Add documentation for taxonomy terms source plugins
| benjifisher | #3189587: Add documentation for taxonomy terms source plugins |
| benjifisher | This is a left-over action item from the previous meeting. Still NR. |
| Matroskeen | Thanks for keeping an eye on it.There are already 3 sub-tasks related to documentation (link to meta issue - #3189481: [Meta] Add source plugin documentation to the codebase)I’m waiting for the review of one of the sub-tasks and will create more. (edited) |
1️⃣2️⃣ SQL source plugins: allow defining conditions in migration yml
| benjifisher | #3069776: SQL source plugins: allow defining conditions and join in migration yml |
| benjifisher | Another action item from the previous meeting. Still NR. |
| quietone | In the meantime, the work was done to simplify the patch by removing the introduction of sub-queries. Should be easier to review. |
| quietone | Did a partial review and it is back to NW. I did not review the tests. |
1️⃣3️⃣ Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface
| benjifisher | #2852463: Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface |
| benjifisher | Waiting for a reply to my review. Some requests from that review are easy to implement. I would like a comment from @heddn or @mikelutz (he/him) on some of the other points. |
1️⃣4️⃣ Expose full set of debugging data in migrate_message table (filterable/searchable)
| benjifisher | #3063856: Add ability to view migrate_message table data |
| benjifisher | Last action item from the previous meeting. @quietone and I have been working on it, and I think we are getting close. |
1️⃣5️⃣ Wrap up
| benjifisher | Thanks for participating! I already updated 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting. |
Participants:
benjifisher, Gábor Hojtsy, damienmckenna, heddn, quietone, Matroskeen
Comments
Comment #2
benjifisherWe agreed not to have a meeting on New Year's Eve, so I am repurposing/retitling this issue for the first meeting of 2021.
I think we should discuss #3143486: Invalid migrations being ignored by the migrate process plugin: migration_lookup, #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance, and related issues.
Comment #3
benjifisherDrush 10.4 will include commands for running migrations based on core code (not migrations defined as config entities using Migrate Plus). See https://gitlab.com/drupalspoons/migrate_tools/-/issues/118.
Comment #4
benjifisherComment #9
quietone commentedComment #10
quietone commented