Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: https://www.drupal.org/project/drupal/issues/3189140. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues:

benjifisher @mikelutz (he/him) @heddn @quietone @phenaproxima (he/him) @Gábor Hojtsy (he/him) @webchick @damienmckenna @benjifisher @alison @Joshua Turton (srjosh) @wimleers (he/him) @dinarcon @steinmb @Ginho @john.ouellet @Nick Dickinson Wilde @Seth Green
benjifisher Is anyone else going to participate on Xmas eve? What about next week, New Year's Eve?
alison Not I :cat_smile-grin:  But hi! :pika-peek: (and thank you!!) (edited)
benjifisher Does "Not I" apply to both today and next week?
alison Oh, correct/yes it does, oops.
heddn nope, busy with family :disappointed:

0️⃣ Who is here today? What are you giving Drupal for the holidays?

benjifisher Benji Fisher, one of the co-maintainers of the migration system. I am taking a week off at the start of January, and I will try to review at least one issue a day M-F that week.
Matroskeen :wave: Ivan from UkraineWill try to push my NW issues.
quietone Vicki, NZ. Reviewing the issues about improving counts and likely responding benjifisher's reviews.

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

Matroskeen Not sure if it deserves a separate thread, but I’m still looking for a better approach to add tests here: #3183226: Specify table alias for File migration source plugin getIds method(maybe can be added to the action items) (edited)

2️⃣ Action items. To be added later.

benjifisher NR: #3189587: Add documentation for taxonomy terms source plugins
benjifisher Carry-over from last week: NR #3069776: SQL source plugins: allow defining conditions and join in migration yml (edited)
benjifisher Carry-over from last week: NW #2852463: Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface. This is a blocker for the Migrate Feeds contrib module. @mikelutz (he/him), RFC.
benjifisher NR: #3063856: Add ability to view migrate_message table data. @benjifisher

3️⃣ Statistics

benjifisher Fixed since last week's meeting: 7. That includes 3 (I think) that were already fixed for 9.1.x and we decided it was too late to back-port them to 9.0.x.
benjifisher RTBC: 4, including 2 Major. All 4 have been updated within the last 3 weeks.
benjifisher NR: 38, including 7 that have been waiting more than 2 months and 6 Major. We need more reviewers to keep up with the patch-submitters.

4️⃣ How can I help? Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

quietone No discussion

5️⃣ Documentation

benjifisher There has been some discussion here and on the #documentation channel in the last week. This meeting is an opportunity for back-and-forth discussion, if that is helpful.
Matroskeen We started adding documentation for SQL source plugins. Here is meta issue: #3189481: [Meta] Add source plugin documentation to the codebase (edited)
Matroskeen The first child issue is set to NR: [#3189587]I’m looking forward to review, because it’ll help us to establish some ground rules that will apply to the rest plugins. (edited)
benjifisher I will add that as an action item.

6️⃣ Expose full set of debugging data in migrate_message table (filterable/searchable)

benjifisher #3063856: Add ability to view migrate_message table data
benjifisher @quietone and I worked on this issue over the weekend. I have to review the latest patch.
benjifisher I reviewed the non-test portions of the patch.

7️⃣ Change records

benjifisher I think that @quietone has been looking through unpublished CRs and publishing some that were missed. Thanks!
benjifisher According to the comments, the CR associated to this issue has incorrect info on the Drupal version where it was introduced: #2830036: MigrationPluginManager::getDefinitions() blows up in node derivers
quietone Just checked and that issue had two CRs, one unfinished duplicate. I missed that have unpublished the one that I should not have published.

8️⃣ Specify table alias for File migration source plugin getIds method

benjifisher #3183226: Specify table alias for File migration source plugin getIds method
benjifisher How to add tests?
benjifisher I just read the issue summary. ...
Matroskeen You can check my patches and then a discussion with @quietone and see if you have a better idea.
benjifisher I just finished reading the comments.
benjifisher Do you want to keep the current issue focused on the File source plugins or expand the scope to look at table aliases on all the SQL source plugins?
benjifisher Is the disagreement just about how to name the test module and its "custom" plugin? Are we still debating whether to use the same test module in future tests or to plan on adding new test modules?
Matroskeen I don’t mind expanding the scope, I’m just trying to avoid bunch of new tests modules with test plugins. (edited)
Matroskeen If we agree, that we 100% need tests for each broken plugin and there is no other way as adding a test module + test plugin that extends the original one, then probably one issue won’t work, because it’ll require many changes in different modules.However, if there is some way to track and cover all plugins at once, then single issue is fine. (edited)
benjifisher Since @quietone is one of the maintainers of the migration system and has a lot of experience with testing, I would defer to her. She recommends not updating a test module for use in future tests. If the test module can be reused as is, that is fine, but it still makes sense to name the test module after what it does (add file usage info to the source) instead of how it is used (in tests).
benjifisher Functional tests are expensive (in run time).  I think it makes sense to add a functional (Kernel) test  here, to make sure that the error we have seen "in real life" has been fixed. If we have a follow-up issue (or meta issue) to look at all the other source plugins, then I hope we can test those with more efficient unit tets.
Matroskeen Ok, thanks for looking!I’ll try to move it back to NR over the holidays :slightly_smiling_face:

9️⃣ Wrap up

benjifisher Thanks for participating! I already updated 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.

Participants:

benjifisher, alison, heddn, Matroskeen, quietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

quietone credited Matroskeen.

quietone credited alisonjo315.

quietone credited benjifisher.

quietone credited heddn.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.