Problem/Motivation

If someone inherits from IndexFactory, it's unexpected that the class mixes static:: and IndexFactory:: invocations.

Steps to reproduce

Try out https://github.com/Gizra/drupal-starter/blob/master/web/modules/custom/s... , the item deletion will be broken as the indexName sometimes comes from IndexFactory directly.

Proposed resolution

Replace the invocation with always static::

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 3190496-es-deletion.patch1.31 KBaron novak

Issue fork elasticsearch_connector-3190496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Aron Novak created an issue. See original summary.

Aron Novak opened merge request !6

Aron Novak opened merge request !7

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs review
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new 3190496-es-deletion.patch1.31 KB

The MR as a patch file.

sokru’s picture

sokru commented
Status: Needs review » Reviewed & tested by the community

Looks good, setting to RTBC.

  • sokru committed 808b25c on 8.x-7.x 
    Issue #3190496 by Aron Novak, sokru: IndexFactory mixes static:: and...
sokru’s picture

sokru commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17 changed the visibility of the branch 8.x-7.x to hidden.

mparker17 closed merge request !6

mparker17 closed merge request !7