[D8] Media Remote Audio

A quick look at the module's code gave me the following impressions:

- Missing composer.json file so it's unclear which versions of Drupal you support (rather important since media is only in core since a specific version).
- Readme file is empty and provides no context at all.
- No hook_help is defined.
- module file is missing the @file doc comment.

I didn't complete any of the other checks yet.

Automated Review

Drupal coding standards report:

❯ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml --ignore=node_modules,bower_components,vendor media_remote_audio

FILE: /Users/bram.driesen/DrupalContrib/web/modules/contrib/media_remote_audio/config/optional/core.entity_form_display.media.remote_audio.media_library.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/bram.driesen/DrupalContrib/web/modules/contrib/media_remote_audio/media_remote_audio.module
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

Time: 108ms; Memory: 8MB

Nothing major or blocking :) no deprecations found and no DrupalPractice violations.

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation. This being for the moment at least until the Drupal Core issue has been implemented.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Does not follow the guidelines for project length and complexity. Module is very small and basically only does a implementation of an alter hook.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I think this is sufficient to get the module itself opted into the security coverage.

One more thing is that you accidentally committed a .DS_Store file.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Whoops... I don't know why 7 years ago ended up there.