Problem/Motivation

Warm up the page cache.

Change something in site settings translation.

Note that whatever you changed is not reflected (translation site name.)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff_4_6.txt836 bytesanmolgoyal74
#6 3189183-6.patch4.02 KBanmolgoyal74
#4 interdiff-2_4.txt862 bytesOscaner
#4 3189183-4.patch4.19 KBOscaner
#2 3189183-2.patch4.2 KBOscaner

Comments

Kang Miao created an issue. See original summary.

Oscaner’s picture

Oscaner commented
StatusFileSize
new 3189183-2.patch4.2 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.8.x-dev » 8.9.x-dev

8.8.x is security only

The test error indicates you need a @group annotation on the test class

Oscaner’s picture

Oscaner commented
StatusFileSize
new 3189183-4.patch4.19 KB
new interdiff-2_4.txt862 bytes

Status: Needs review » Needs work

The last submitted patch, 4: 3189183-4.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs work » Needs review
StatusFileSize
new 3189183-6.patch4.02 KB
new interdiff_4_6.txt836 bytes

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work
Issue tags: +Needs tests, +Bug Smash Initiative

This needs tests, but this change might have a very harsh impact on caching, however I agree this change is needed.

Let's start by adding the tests.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mstrelan’s picture

mstrelan commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Needs steps to reproduce

I cannot reproduce this, perhaps it has been fixed. Can anyone provide steps to reproduce? Here's what I tried:

  1. Install standard profile and config translation module, uninstall page cache module
  2. Install Afrikaans language
  3. Logout and visit /af, get a dynamic page cache MISS, reload page and get a HIT
  4. Login, edit site settings for Afrikaans, change the site name
  5. Repeat step 3, noticing the updated site name immediately
mohit_aghera’s picture

mohit_aghera commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

This came up in bugsmash triage today.
It seems we don't have any updates on steps to reproduce after 3 months.
Hence closing the ticket.

Please reopen, if you feel you are facing issue again.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.