Problem/Motivation

In #1136482: [policy] Deprecate aggregator.module in D9 core and remove it in D10 we've agreed to deprecate the Aggregator module for removal in Drupal 10, along with Laminas Feed (which only Aggregator depends on).

This issue is to coordinate and track the steps needed to move Aggregator to contrib. See Remove a core module and move it to a contributed project of the deprecation policy.

Proposed resolution

Remaining tasks

  1. Move integrations implemented by other modules to Aggregator module
  2. Create the contrib project, Aggregator, with a stable release. @larowlan and @andypost have offered to maintain the contributed module.
  3. Deprecate the core Aggregator module

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

Currently postponed on:

Issue fork drupal-3188549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

xjm created an issue. See original summary.

xjm’s picture

Issue summary: View changes
andypost’s picture

Looks the related could be closed now

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

darren oh’s picture

I suspect that #2940739: Project messaging channel in core initiative will end up recreating the Aggregator module in core. I would like to see whatever is created for that initiative made reusable for custom feeds. Feeds in core would not replace Aggregator because Feeds does not provide item and source entity types. Aggregator has usability issues, but if they were addressed, I think it would be used more widely. Now that we have a compelling use case, Aggregator deserves a second look.

catch’s picture

Title: [PP-1] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Status: Postponed » Needs work

We now have 'lifecycle' in .info.yml files, so this is unblocked.

However, noting #5 - if we do actually want to display RSS feeds in core, then we shouldn't rebuild aggregator.

kim.pepper made their first commit to this issue’s fork.

kim.pepper’s picture

Status: Needs work » Needs review

Step 1.

andypost’s picture

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

Issue summary: View changes
spokje’s picture

Title: Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-1] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Status: Needs review » Postponed

Besides the current patch needing to be against 9.4.x-dev and having no lifecycle_link, the procedure for deprecating/removing Core modules, currently is roughly like this:

- Move all tests related to the module to be deprecated/removed into both the module directory and namespace.
- Copy module to its own Contrib module.
- Move open issues concerning module from the core queue to the above Contrib queue
- Deprecate module in 9.4.x
- Delete module in 10.0.x

Seeing that deprecating/removing this module also includes removing some core dependencies, the above might be more elaborate.
I'll leave that to Bigger Brains.

For now I've opened #3264120: Remove aggregator module and our dependency on Laminas Feed for a straight up removal of core/modules/aggregator directory and laminas/* dependencies to see what breaks and needs to be moved/fixed in #3264122: Move all non migration aggregator tests to the module in preparation of removal in d10

spokje’s picture

spokje’s picture

Title: [PP-1] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-2] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10

Seeing that #3263654: Move all HAL tests to the module in preparation of removal in D10 will move a lot (8 in fact) of tests away from the aggregator module, it makes sense to also postpone moving this module to Contrib on the commit of that issue.

xjm’s picture

We also need to figure out how to handle aggegator's data migrations -- both what happens to the migration paths for Aggregator, and how we handle the data for a D9 to D10 upgrade when Aggregator is installed on the D9 site.

berdir’s picture

Not sure why we need to migrate the data? There won't be a replacement data structure in core, people will either need to uninstall the module or switch to the contrib module at the same time as updating core, and then their data will continue to work (and if not it will be the responsibility of the contrib module if that made changes?)

catch’s picture

As long as aggregator's migration path from Drupal 6/7 is self-contained, it should be fine to move that to contrib - it'll all have the same namespaces etc. The issue we're likely to hit though is the core test database fixture for migrate having aggregator data in it. I think we will probably want to just leave the aggregator data in the core fixture to keep things simple, and then the fixture will eventually go when we move the d6/d7 migrations to contrib.

spokje’s picture

Title: [PP-2] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-3] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Issue summary: View changes
Related issues: +#3265424: Move migrate related aggregator tests to the module in preparation of removal in d10, +#3263654: Move all HAL tests to the module in preparation of removal in D10, +#3264122: Move all non migration aggregator tests to the module in preparation of removal in d10

Before the aggregator module as-is can be moved to Contrib (which is around the same time it can be deprecated), the moving of the migrate related aggregator tests also has to be committed.

PP+1 on #3265424: Move migrate related aggregator tests to the module in preparation of removal in d10.

spokje’s picture

Title: [PP-3] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-2] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Issue summary: View changes
quietone’s picture

Title: [PP-2] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-3] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Issue summary: View changes

I put the migration issue as a blocker as well.

spokje’s picture

Title: [PP-3] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [PP-4] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Issue summary: View changes
Related issues: +#3267052: Move aggregator help topics to aggregator module

I've (tentatively) put the help topics move #3267052: Move aggregator help topics to aggregator module as a blocker as well.

quietone’s picture

Title: [PP-4] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [Meta] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10
Issue summary: View changes
Parent issue: #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 » #1136482: [policy] Deprecate aggregator.module in D9 core and remove it in D10
Related issues: -#1136482: [policy] Deprecate aggregator.module in D9 core and remove it in D10

Updating remaining tasks with the steps in the module deprecation policy. Removing postponed from the title because there may be steps that can we worked on, or created, while waiting on the issues in step 1 to be finished.

quietone’s picture

Issue summary: View changes
Status: Postponed » Active

Fix typo

quietone’s picture

Issue summary: View changes

Add deprecation issue.

quietone’s picture

larowlan’s picture

I've pushed the code to the aggregator contributed project. I'll need to add a composer.json but I'll do that once we're good to go so I can keep pushing from the subtree split

quietone’s picture

The needed lifecycle_link is to point to a new section on the recommendation page, https://www.drupal.org/node/3223395#s-aggregator. And the CR needs to include that link as well.

spokje’s picture

@quiteone

The needed lifecycle_link is to point to a new section on the recommendation page, https://www.drupal.org/node/3223395#s-aggregator. And the CR needs to include that link as well.

Right on both accounts, but it seems, like me, and because of me, you're tricked by (the most part of) the issue title and the MR (BTW against 9.3) in this issue.
This is the [Meta], which means the Big Brains hang out in here, and the grunt work is done in the child issues. For the actual deprecation that's #3267458: Deprecate aggregator module in Drupal 9.4. I'll add the CR and correct lifecycle_link in the MR over there.

Again: Sorry for causing confusion by blindly updating the MR in here, instead of the actual [DoStuffHere] issue and starting this whole derailment...

quietone’s picture

@Spokje, thanks for the explanation. I did think it was odd having an MR in this Meta but I didn't stop to look further. And now that I do I see that I opened #3267458: Deprecate aggregator module in Drupal 9.4 two weeks ago. Feels like too many irons in the fire...

catch’s picture

Opened #3272246: Ensure that aggregator doesn't get special core treatment against project_composer, and #3272247: Stable release against aggregator.

Last step is to move the issues across - still @todo.

spokje’s picture

spokje’s picture

spokje’s picture

Issue summary: View changes
quietone’s picture

Title: [Meta] Deprecate both Aggregator and our dependency on Laminas Feed for removal in Drupal 10 » [Meta] Tasks to deprecate both Aggregator and our dependency on Laminas Feed
Issue summary: View changes
Related issues: +#3274189: [Meta] Tasks to remove both Aggregator and our dependency on Laminas Feed
andypost’s picture

Status: Active » Fixed

All child issues are done and summary tasks are completed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.