Closed (fixed)
Project:
Aggregator
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2022 at 14:07 UTC
Updated:
14 Jul 2023 at 20:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlan1.0.0 is out
Comment #3
larowlanComposer issues, unpublished the release, waiting until I can get tests passing before I make another one
Asked in slack for some help as to why Drupal CI won't install laminas/feed-reader even though I have a composer.json
Comment #4
larowlanStill blocked on tests
Have triaged the queue down to a single page of active issues though
Comment #5
dcam commentedThis patch is an attempt at getting the 1.x branch to pass tests. Here's a summary of the changes that were made:
Comment #7
dcam commentedI'm not sure what's wrong here. It kind of looks like it didn't apply the patch when testing #5. So I decided to try a MR instead. To be honest, I don't use MRs very often. So I hopefully I'm doing this correctly.
Comment #8
dcam commentedOk, my reading comprehension was either really bad when checking the errors for #5 or it's been too long since I've done any serious contribution work. Because it's obvious now what the problems are. In the end I literally just copied the same changes that were made for the 2.x branch in #3294389: Fix fails in HEAD for the migrate_drupal_ui tests, stripping most of them out. They passed for me locally.
Oh, and I removed the changes to composer.json. I think maybe they can/should be tackled separately.
Comment #9
dcam commentedYay, everything is passing.
Comment #10
larowlanNice, this should be heaps less brittle
Comment #12
dcam commentedSince this was essentially a backport from 2.x I went ahead and committed it.