Problem/Motivation

Aggregator has been removed from core. It would be good to update the subtree split and tag a release.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3272247-8.patch31.13 KBdcam
#8 interdiff.txt30.11 KBdcam
#5 3272247-5.patch4.75 KBdcam

Issue fork aggregator-3272247

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

larowlan’s picture

Status: Active » Fixed

1.0.0 is out

larowlan’s picture

Version: » 1.x-dev
Status: Fixed » Needs work

Composer issues, unpublished the release, waiting until I can get tests passing before I make another one

Asked in slack for some help as to why Drupal CI won't install laminas/feed-reader even though I have a composer.json

larowlan’s picture

Still blocked on tests

Have triaged the queue down to a single page of active issues though

dcam’s picture

Status: Needs work » Needs review
StatusFileSize
new4.75 KB

This patch is an attempt at getting the 1.x branch to pass tests. Here's a summary of the changes that were made:

  • Removed the core version requirement from composer.json, as recommended by https://www.drupal.org/docs/develop/creating-modules/add-a-composerjson-.... This also removed D10 compatibility for the branch, which was causing problems because it isn't compatible.
  • Removed Color and RDF module checks from tests. I suspect that they were causing failures because those modules were removed from the standard profile, but to be honest I didn't dig into it.
  • Changed the D6 block migration test to use Stark instead of Bartik. I just copied the same test from the 2.x branch for simplicity.

dcam’s picture

I'm not sure what's wrong here. It kind of looks like it didn't apply the patch when testing #5. So I decided to try a MR instead. To be honest, I don't use MRs very often. So I hopefully I'm doing this correctly.

dcam’s picture

StatusFileSize
new30.11 KB
new31.13 KB

Ok, my reading comprehension was either really bad when checking the errors for #5 or it's been too long since I've done any serious contribution work. Because it's obvious now what the problems are. In the end I literally just copied the same changes that were made for the 2.x branch in #3294389: Fix fails in HEAD for the migrate_drupal_ui tests, stripping most of them out. They passed for me locally.

Oh, and I removed the changes to composer.json. I think maybe they can/should be tackled separately.

dcam’s picture

Yay, everything is passing.

larowlan’s picture

Nice, this should be heaps less brittle

  • dcam committed 2f1c02ac on 1.x
    Issue #3272247 by dcam: Stable release
    
dcam’s picture

Status: Needs review » Fixed

Since this was essentially a backport from 2.x I went ahead and committed it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.