The Drupal Core Mentoring Coordinators are delighted to invite Brian Gilbert (realityloop) to the list of Provisional Mentoring Coordinators, listed in MAINTAINERS.txt

We have discussed the responsibilities of the role and, indeed, agreed that a primary task for those joining as provisional members in this update will be to better document the processes we follow.

Issue fork drupal-3187241

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rachel_norfolk created an issue. See original summary.

rachel_norfolk’s picture

Issue tags: +Europe2020

Hey, I’m at DrupalCon Europe 2020 so adding the tag!

xjm’s picture

I was surprised Brian wasn't already listed! He's been making our mentoring tools and training awesome since forever.

The next step is for @realityloop to confirm on the issue that he accepts the role as described in MAINTAINERS.txt:

Mentoring coordinators recruit and coach other mentors. They work on contributor tools, documentation, and processes to make it easier for new contributors to get involved. They organize communications and logistics, and actively participate in mentoring.

As well as the general maintainer role as described in the core governance.

And we'll need a patch against MAINTAINERS.txt. :)

Hooray!

Pooja Ganjage’s picture

StatusFileSize
new494 bytes

Hi,

Creating a patch to include Brian Gilbert (realityloop) as a provisional mentoring coordinator in MAINTAINERS.txt.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Status: Active » Needs review
chrisdarke’s picture

Thanks! Still waiting on Brian to actually give written confirmation first on this.

volkswagenchick’s picture

Status: Needs review » Needs work
Related issues: +#3187239: Add Chris Darke (ChrisDarke) as a provisional mentoring coordinator

Adding a related issue. Wondering if all three issues should be addressed in one patch?

Moving this to needs work as Brian has yet to comment.

chrisdarke’s picture

I did think about that but since they were separate issues I wasn't sure what the protocol was to bundle them together.

Pooja Ganjage’s picture

StatusFileSize
new638 bytes

Hi,

Creating a patch as added all three in one as a provisional mentoring coordinator in MAINTAINERS.txt.'

Please review the patch.

Thanks.

Pooja Ganjage’s picture

StatusFileSize
new637 bytes
chrisdarke’s picture

Hi @pooja-ganjage we are still waiting on @realityloop to confirm this nomination, so as such it's a bit premature to push up a patch for this. Doubt he will NOT confirm, but just to keep the order of events right.
I am open to debate on this though of course!

volkswagenchick’s picture

Thanks for the patch. I do think for consistency the names should be in alphabetical order by last name as the list above this section. thanks.

Example.
- Mauricio Dinarte 'dinarcon' https://www.drupal.org/u/dinarcon
- Lucas Hedding 'heddn' https://www.drupal.org/u/heddn
- Tara King 'sparklingrobots' https://www.drupal.org/u/sparklingrobots
- Rachel Lawson 'rachel_norfolk' https://www.drupal.org/u/rachel_norfolk
- Elli Ludwigson 'ekl1773' https://www.drupal.org/u/ekl1773
- Jess Myrbo 'xjm' https://www.drupal.org/u/xjm
- Matthew Radcliffe 'mradcliffe' https://www.drupal.org/u/mradcliffe

Pooja Ganjage’s picture

StatusFileSize
new637 bytes

Created patch as suggested in #12 comment.

Thanks.

xjm’s picture

@Pooja Ganjage, thanks for your help, but let's stop posting patches until we have feedback from Brian on the issue. The appointees are independent of each other on purpose because it's not a "package deal" -- only one might accept the role, or all three, etc. :) So let's wait for now rather than rolling patches that might just need to be rerolled anyway.

realityloop’s picture

@rachel_norfolk @xjm happy to accept addition, apologies for the delay in response.

Pooja Ganjage’s picture

Status: Needs work » Needs review

Needs Review as @realityloop accepted as a provisional mentoring coordinator.

chrisdarke’s picture

@Pooja Ganjage, regarding https://www.drupal.org/project/drupal/issues/3187241#comment-13933959, the commits are being kept seperately, and per @xjm, adding them into the main listing with (provisional) in front

annikaC’s picture

Status: Needs review » Reviewed & tested by the community

Congratulations @realityloop !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

@realityloop I think we need a comment like #3187239-6: Add Chris Darke (ChrisDarke) as a provisional mentoring coordinator to agree to everything outlined by @xjm in #3

Pooja Ganjage’s picture

Status: Needs work » Needs review
chrisdarke’s picture

Hi Pooja, what Alex was referring to in their comment was that Brian needs to add in a more detailed acceptance of the task he is being asked to perform. Something along the lines of what I wrote in mine:

"I confirm that I accept the role as described in MAINTAINERS.txt, and the general role of a maintainer as covered in the core governance."

Until he does that we cannot move forwards with any updates to this issue. I thought that his previous comment in #15 was enough but it was not. Let me know if you have any questions about this :)

chrisdarke’s picture

Status: Needs review » Needs work
rachel_norfolk’s picture

/me just pinged Brian asking for the exact comment adding...

realityloop’s picture

Status: Needs work » Needs review

sorry for the delay, we need ability to set notifications on @mentions on D.o!

I confirm that I accept the role as described in MAINTAINERS.txt, and the general role of a maintainer as covered in the core governance.

volkswagenchick’s picture

Status: Needs review » Needs work

Thanks Brian!!

I am moving this issue to Needs work. The patch/merge request will have to updated due to recent updates to that file.

Thanks!

rachel_norfolk’s picture

Status: Needs work » Needs review

Well, I was bound to get something wrong on first try with merge requests!! Got too used to patches over the years.

The end result looks right, though.

I'm thinking we need to follow-up issue to remove "Provisional membership: None at this time." if someone would oblige...

thejimbirch’s picture

Status: Needs review » Reviewed & tested by the community

Seeing 135 commits was a bit weird, but yes, ultimately, the only code change is what is needed for this issue. My guess is the merging of changes to the main branch is not relevant in the end, and only on the fork.

I am going to change this to RTBC to see if a maintainer agrees.

thejimbirch’s picture

Added Related issue per the comment in #27

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 7ccaa8faa5 to 9.2.x and db5f7f243b to 9.1.x. Thanks!

  • alexpott committed 7ccaa8f on 9.2.x
    Issue #3187241 by realityloop: Add Brian Gilbert (realityloop) as a...

  • alexpott committed db5f7f2 on 9.1.x
    Issue #3187241 by realityloop: Add Brian Gilbert (realityloop) as a...
chrisdarke’s picture

@rachel_norfolk I had created an issue regarding tidying up Maintainers.txt and that lead into a longer discussion about what the entries should say, and this was merged by Gabor into this issue https://www.drupal.org/project/drupal/issues/3191699

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.