The Drupal Core Mentoring Coordinators are delighted to invite Brian Gilbert (realityloop) to the list of Provisional Mentoring Coordinators, listed in MAINTAINERS.txt
We have discussed the responsibilities of the role and, indeed, agreed that a primary task for those joining as provisional members in this update will be to better document the processes we follow.
| Comment | File | Size | Author |
|---|
Issue fork drupal-3187241
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3187241-add-brian-gilbert
changes, plain diff MR !137
Comments
Comment #2
rachel_norfolkHey, I’m at DrupalCon Europe 2020 so adding the tag!
Comment #3
xjmI was surprised Brian wasn't already listed! He's been making our mentoring tools and training awesome since forever.
The next step is for @realityloop to confirm on the issue that he accepts the role as described in
MAINTAINERS.txt:As well as the general maintainer role as described in the core governance.
And we'll need a patch against
MAINTAINERS.txt. :)Hooray!
Comment #4
Pooja Ganjage commentedHi,
Creating a patch to include Brian Gilbert (realityloop) as a provisional mentoring coordinator in MAINTAINERS.txt.
Please review the patch.
Thanks.
Comment #5
Pooja Ganjage commentedComment #6
chrisdarke commentedThanks! Still waiting on Brian to actually give written confirmation first on this.
Comment #7
volkswagenchickAdding a related issue. Wondering if all three issues should be addressed in one patch?
Moving this to needs work as Brian has yet to comment.
Comment #8
chrisdarke commentedI did think about that but since they were separate issues I wasn't sure what the protocol was to bundle them together.
Comment #9
Pooja Ganjage commentedHi,
Creating a patch as added all three in one as a provisional mentoring coordinator in MAINTAINERS.txt.'
Please review the patch.
Thanks.
Comment #10
Pooja Ganjage commentedComment #11
chrisdarke commentedHi @pooja-ganjage we are still waiting on @realityloop to confirm this nomination, so as such it's a bit premature to push up a patch for this. Doubt he will NOT confirm, but just to keep the order of events right.
I am open to debate on this though of course!
Comment #12
volkswagenchickThanks for the patch. I do think for consistency the names should be in alphabetical order by last name as the list above this section. thanks.
Example.
- Mauricio Dinarte 'dinarcon' https://www.drupal.org/u/dinarcon
- Lucas Hedding 'heddn' https://www.drupal.org/u/heddn
- Tara King 'sparklingrobots' https://www.drupal.org/u/sparklingrobots
- Rachel Lawson 'rachel_norfolk' https://www.drupal.org/u/rachel_norfolk
- Elli Ludwigson 'ekl1773' https://www.drupal.org/u/ekl1773
- Jess Myrbo 'xjm' https://www.drupal.org/u/xjm
- Matthew Radcliffe 'mradcliffe' https://www.drupal.org/u/mradcliffe
Comment #13
Pooja Ganjage commentedCreated patch as suggested in #12 comment.
Thanks.
Comment #14
xjm@Pooja Ganjage, thanks for your help, but let's stop posting patches until we have feedback from Brian on the issue. The appointees are independent of each other on purpose because it's not a "package deal" -- only one might accept the role, or all three, etc. :) So let's wait for now rather than rolling patches that might just need to be rerolled anyway.
Comment #15
realityloop commented@rachel_norfolk @xjm happy to accept addition, apologies for the delay in response.
Comment #16
Pooja Ganjage commentedNeeds Review as @realityloop accepted as a provisional mentoring coordinator.
Comment #18
chrisdarke commented@Pooja Ganjage, regarding https://www.drupal.org/project/drupal/issues/3187241#comment-13933959, the commits are being kept seperately, and per @xjm, adding them into the main listing with (provisional) in front
Comment #19
annikaC commentedCongratulations @realityloop !
Comment #20
alexpott@realityloop I think we need a comment like #3187239-6: Add Chris Darke (ChrisDarke) as a provisional mentoring coordinator to agree to everything outlined by @xjm in #3
Comment #21
Pooja Ganjage commentedComment #22
chrisdarke commentedHi Pooja, what Alex was referring to in their comment was that Brian needs to add in a more detailed acceptance of the task he is being asked to perform. Something along the lines of what I wrote in mine:
"I confirm that I accept the role as described in MAINTAINERS.txt, and the general role of a maintainer as covered in the core governance."
Until he does that we cannot move forwards with any updates to this issue. I thought that his previous comment in #15 was enough but it was not. Let me know if you have any questions about this :)
Comment #23
chrisdarke commentedComment #24
rachel_norfolk/me just pinged Brian asking for the exact comment adding...
Comment #25
realityloop commentedsorry for the delay, we need ability to set notifications on @mentions on D.o!
I confirm that I accept the role as described in MAINTAINERS.txt, and the general role of a maintainer as covered in the core governance.
Comment #26
volkswagenchickThanks Brian!!
I am moving this issue to Needs work. The patch/merge request will have to updated due to recent updates to that file.
Thanks!
Comment #27
rachel_norfolkWell, I was bound to get something wrong on first try with merge requests!! Got too used to patches over the years.
The end result looks right, though.
I'm thinking we need to follow-up issue to remove "Provisional membership: None at this time." if someone would oblige...
Comment #28
thejimbirch commentedSeeing 135 commits was a bit weird, but yes, ultimately, the only code change is what is needed for this issue. My guess is the merging of changes to the main branch is not relevant in the end, and only on the fork.
I am going to change this to RTBC to see if a maintainer agrees.
Comment #29
thejimbirch commentedAdded Related issue per the comment in #27
Comment #30
alexpottCommitted and pushed 7ccaa8faa5 to 9.2.x and db5f7f243b to 9.1.x. Thanks!
Comment #33
chrisdarke commented@rachel_norfolk I had created an issue regarding tidying up Maintainers.txt and that lead into a longer discussion about what the entries should say, and this was merged by Gabor into this issue https://www.drupal.org/project/drupal/issues/3191699