Problem/Motivation

Notice when going to "Sources" option on TMGMT

Error when searching for a title on "Sources" of TMGMT

Steps to reproduce

Press option "Sources"

This is the notice message:

Notice: Trying to access array offset on value of type null in Drupal\tmgmt\SourcePluginUiBase->buildTranslationStatus() (line 332 of modules/contrib/tmgmt/src/SourcePluginUiBase.php).
CommentFileSizeAuthor
#7 icons-3186032-7.patch834 bytesguillaumeduveau

Issue fork tmgmt-3186032

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrochate created an issue. See original summary.

jrochate’s picture

jrochate commented
Issue summary: View changes
jrochate’s picture

jrochate commented

Changed config to less rows per page and now the notice is off.

source_list_limit: 100

quick_checkout: true
anonymous_access: true
purge_finished: _never
word_count_exclude_tags: true
source_list_limit: 100
respect_text_format: true
submit_job_item_on_cron: false
job_items_cron_limit: 50
allowed_formats: {  }
_core:
  default_config_hash: kNAclv7Nq8cW0Huko5DpTk2YAMaXNiCVB9iZON_MNHc
langcode: pt-pt
jrochate’s picture

jrochate commented
Status: Active » Closed (works as designed)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Closed (works as designed) » Active

I've seen that error too on a client project.. By setting a lower row limit, you might have just pushed the problematic node to a later page. You might see it again if you go through the pager..

guillaumeduveau’s picture

guillaumeduveau
Location Toulouse
commented

Icons are missing for the last 3 states in JobItem::getStateDefinitions()

guillaumeduveau’s picture

guillaumeduveau
Location Toulouse
commented
Status: Active » Needs review
StatusFileSize
new icons-3186032-7.patch834 bytes

Status: Needs review » Needs work

The last submitted patch, 7: icons-3186032-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Looking closer at this, there are multiple aspects.

Some item states don't have an icon on purpose, we don't want to give accepted/aborted items any extra visibility, they are completed.

accepted are already excluded and should not show up there. aborted might show up if they are part of a active/continuous job but we don't want that, so I excluded them in the underlying API method. And inactive items can show up when you create a job with a predefined target language but then don't submit it. I'm on the fence if we should show those. The labels are kinda weird (Active job item: inactive o.0), but on the other hand, it has been created and it's an open job that you might want to submit still. You can always abort/delete it. And I'd rather not change existing translatable strings if I don't have to.

For the inactive job item, I used the same icon as unprocessed jobs.

Berdir opened merge request !8

  • Berdir committed b131c5c on 8.x-1.x 
    Issue #3186032 by GuillaumeDuveau: Notice: Trying to access array offset...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.