[META] Roadmap to Drupal 9 support

This patch only modifies the composer.jsonto the point where dependencies resolve.

Three modules have been excluded at this point: views_menu_children_filter, term_condition, and better_formats.

Attached is a patch that doesn't quite work, but it updates the info files of all Sector modules and then modifies/removes any config related to the 3 contrib modules currently not Drupal 9 ready. There are still some config errors to work through, and hopefully all these config changes can be reverted once the relevant modules provide basic support.

The error I am facing is related to this change record: https://www.drupal.org/node/2481909

There is some discussion around the vagueness of the error and tracking down just which config will need to be updated: #3132759: ConfigEntityType "missing 'config_export" error message doesn't say what annotation is missing

Message:

Drupal\Core\Config\Schema\SchemaIncompleteException: Entity type 'Drupal\Core\Config\Entity\ConfigEntityType' is missing 'config_export' definition in its annotation in Drupal\Core\Config\Entity\ConfigEntityBase->toArray() (line 251 of core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php).
Drupal\Core\Config\Entity\ConfigEntityBase->toArray() (Line: 311)
Drupal\Core\Config\Entity\ConfigEntityStorage->mapToStorageRecord(Object) (Line: 283)
Drupal\Core\Config\Entity\ConfigEntityStorage->doSave('blockquote_full_text_align_left_with_cite', Object) (Line: 452)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 263)
Drupal\Core\Config\Entity\ConfigEntityStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 591)
Drupal\Core\Config\Entity\ConfigEntityBase->save() (Line: 159)
Drupal\wysiwyg_template\Entity\Template->save() (Line: 373)
Drupal\Core\Config\ConfigInstaller->createConfiguration('', Array) (Line: 137)
Drupal\Core\Config\ConfigInstaller->installDefaultConfig('module', 'sector') (Line: 75)
Drupal\Core\ProxyClass\Config\ConfigInstaller->installDefaultConfig('module', 'sector') (Line: 287)
Drupal\Core\Extension\ModuleInstaller->install(Array, ) (Line: 83)
Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array, ) (Line: 1655)
install_install_profile(Array) (Line: 693)
install_run_task(Array, Array) (Line: 568)
install_run_tasks(Array, NULL) (Line: 118)
install_drupal(Object) (Line: 44)

Since Term Condition has just had a new release that is D9 compatible, here is a re-roll with it added back in and config affected restored.

That should reduce the size a bit.

The Better Formats issue is currently being worked on separately.

Likely I will create a few separate issues to break this task up soon, but I'd first like to have a working semi-functional install via this mega patch so that we know the scope.

Breaking up the big patch into smaller chunks - once these have been pushed to the 9.1.x branch then it will be much easier to review what still needs to be done, as testing has become difficult without the recipe changes committed to a branch that composer can build from.

One update on the previous install errors. I figured from the stack trace that there was something to do with the config of WYSIWYG Templates. I simply ran rm config/install/wysiwyg_template.wysiwyg_template.* as a quick workaround.

Sector then finished install without fatal errors!

On the post-install screen, I got the following error: The fetched resource did not have a valid Content-Type header. That's a bit vague and needs some more research.

It seems like some blocks are missing from the front page, including the main menu.

On visiting admin views, I also saw the following warning repeated: Warning: Illegal string offset 'action_id' in Drupal\views_bulk_operations\Plugin\views\field\ViewsBulkOperationsBulkForm->getBulkOptions() (line 784 of modules/contrib/views_bulk_operations/src/Plugin/views/field/ViewsBulkOperationsBulkForm.php).

UPDATE: We need to make a few manual tweaks to our VBO default config: #3116228: Warning: Illegal string offset 'action_id' - which removes the action checkbox in views

When trying to add a WYSIWYG Template the following notice: Notice: Trying to access array offset on value of type null in Drupal\wysiwyg_template\Entity\Template->getBundles() (line 140 of modules/contrib/wysiwyg_template/src/Entity/Template.php).

This can be fixed by adding the following key to each default config template:

entity_types:
  block_content: {  }
  media: {  }
  node: {  }
  taxonomy_term: {  }

Trying to add a new template gives the same error I was experiencing on install, which likely means the module needs a patch to be fully D9 compatible.

UPDATE: I have submitted a patch which we can test with Sector - #3186405: Define config_export annotation on Template entity

I've update the default sector-project template with a new branch that uses Drupal 9 and Drush 10.

You can now build and install Sector 9 with a single command:

composer create-project sparksinteractive/sector-project:9.x-dev {project-name}

I am going to release an alpha build while we work on the upgrade path and continue to discover new issues.

Adding a few possible issues to review.

Things are in a good state, and alpha1 will be tagged before the end of today.