ConfigEntityType "missing 'config_export" error message doesn't say what annotation is missing [#3132759]

If an annotation doesn't have a "config_export" item the error message says:

Drupal\Core\Config\Schema\SchemaIncompleteException: Entity type 'Drupal\Core\Config\Entity\ConfigEntityType' is missing 'config_export' definition in its annotation

It would be more useful if the error message indicated what the annotation is for, it would help track down which annotation is missing the item.

Comment	File	Size	Author
#16	interdiff_13_16.txt	894 bytes	anmolgoyal74
#16	drupal-config_export_annotation-3132759-16.patch	1.92 KB	anmolgoyal74
#16	9.0.x: PHP 7.3 & MySQL 5.7 27,443 pass 9.2.x: PHP 7.4 & MySQL 5.7 27,823 pass 9.1.x: PHP 7.4 & MySQL 5.7 27,819 pass
#14	interdiff_7-13.txt	1.67 KB	mvonfrie
#13	drupal-config_export_annotation-3132759-13.patch	1.95 KB	mvonfrie
#13	9.0.x: PHP 7.3 & MySQL 5.7 27,442 pass PHP 7.4 & MySQL 5.7 27,442 pass 9.1.x: PHP 7.4 & MySQL 5.7 27,819 pass
#12	drupal-config_export_annotation-3132759-12.patch	1.95 KB	mvonfrie
#12	9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
#11	drupal-config_export_annotation-3132759-11.patch	1.98 KB	mvonfrie
#11	9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
#10	interdiff_7-10.txt	1.69 KB	mvonfrie
#10	drupal-config_export_annotation-3132759-10.patch	1.98 KB	mvonfrie
#10	9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
#9	interdiff_7-9.txt	1.69 KB	mvonfrie
#9	drupal-config_export_annotation-3132759-9.patch	1.98 KB	mvonfrie
#9	9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply PHP 7.4 & MySQL 5.7 Patch Failed to Apply 9.1.x: PHP 7.4 & MySQL 5.7 Patch Failed to Apply
#7	interdiff-5-7.txt	944 bytes	AaronBauman
#7	drupal-config_export_annotation-3132759-7.patch	1.95 KB	AaronBauman
#7	9.0.x: PHP 7.3 & MySQL 5.7 27,299 pass PHP 7.4 & MySQL 5.7 Patch Failed to Apply
#5	interdiff-2-5.txt	747 bytes	AaronBauman
#5	drupal-config_export_annotation-3132759-5.patch	1.81 KB	AaronBauman
#5	9.0.x: PHP 7.3 & MySQL 5.7 27,276 pass, 1 fail
#2	drupal-config_export_annotation-3132759-2.patch	940 bytes	AaronBauman
#2	9.0.x: PHP 7.3 & MySQL 5.7 27,276 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 May 2020 at 03:05

DamienMcKenna created an issue. See original summary.

Comment #2

AaronBauman

he/him

CreditAttribution: AaronBauman at Message Agency commented 21 May 2020 at 16:32

Status:

Active

» Needs review

File	Size
drupal-config_export_annotation-3132759-2.patch	940 bytes
9.0.x: PHP 7.3 & MySQL 5.7 27,276 pass, 1 fail

ConfigEntityTypeInterface defines a getClass() method
We should just use that, which will return the specific class with the annotation issue.

One-liner

Comment #3

21 May 2020 at 17:37

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal-config_export_annotation-3132759-2.patch, failed testing. View results

Comment #4

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented 21 May 2020 at 17:41

Assigned:

Unassigned

» pavnish

Comment #5

AaronBauman

he/him

CreditAttribution: AaronBauman at Message Agency commented 21 May 2020 at 19:57

Status:

Needs work

» Needs review

File	Size
drupal-config_export_annotation-3132759-5.patch	1.81 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,276 pass, 1 fail
interdiff-2-5.txt	747 bytes

Update test coverage for this change.

Comment #6

21 May 2020 at 21:00

Status:

Needs review

» Needs work

The last submitted patch, 5: drupal-config_export_annotation-3132759-5.patch, failed testing. View results

Comment #7

AaronBauman

he/him

CreditAttribution: AaronBauman at Message Agency commented 22 May 2020 at 15:10

Status:

Needs work

» Needs review

File	Size
drupal-config_export_annotation-3132759-7.patch	1.95 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,299 pass PHP 7.4 & MySQL 5.7 Patch Failed to Apply
interdiff-5-7.txt	944 bytes

1 file was hidden/shown/deleted

File	Size
drupal-config_export_annotation-3132759-2.patch	940 bytes
9.0.x: PHP 7.3 & MySQL 5.7 27,276 pass, 1 fail

Fixed test coverage.

Comment #8

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented 4 June 2020 at 17:58

Assigned:

pavnish

» Unassigned

Comment #9

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 25 November 2020 at 20:15

File

Size

drupal-config_export_annotation-3132759-9.patch

1.98 KB

9.1.x:
PHP 7.4 & MySQL 5.7 Patch Failed to Apply

interdiff_7-9.txt

1.69 KB

Fixed the patch for 9.0.x.
The method TestCase::expectDeprecationMessageRegExp() has been renamed to TestCase::expectDeprecationMessageMatches().

Comment #10

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 25 November 2020 at 20:26

File	Size
drupal-config_export_annotation-3132759-10.patch	1.98 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
interdiff_7-10.txt	1.69 KB

The patched code ends with a blank line which somehow was also shown by the IDE in the #7 patch. Removed the second blank line at the end and hope this works now.

Comment #11

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 25 November 2020 at 20:30

File	Size
drupal-config_export_annotation-3132759-11.patch	1.98 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply

Comment #12

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 25 November 2020 at 20:39

File	Size
drupal-config_export_annotation-3132759-12.patch	1.95 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply

Comment #13

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 25 November 2020 at 20:42

File	Size
drupal-config_export_annotation-3132759-13.patch	1.95 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,442 pass PHP 7.4 & MySQL 5.7 27,442 pass 9.1.x: PHP 7.4 & MySQL 5.7 27,819 pass

File

Size

drupal-config_export_annotation-3132759-13.patch

1.95 KB

9.1.x:
PHP 7.4 & MySQL 5.7 27,819 pass

Comment #14

mvonfrie CreditAttribution: mvonfrie as a volunteer and commented 26 November 2020 at 12:59

File	Size
interdiff_7-13.txt	1.67 KB

6 files were hidden/shown/deleted

File	Size
drupal-config_export_annotation-3132759-9.patch	1.98 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply PHP 7.4 & MySQL 5.7 Patch Failed to Apply 9.1.x: PHP 7.4 & MySQL 5.7 Patch Failed to Apply
interdiff_7-9.txt	1.69 KB
drupal-config_export_annotation-3132759-10.patch	1.98 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
interdiff_7-10.txt	1.69 KB
drupal-config_export_annotation-3132759-11.patch	1.98 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply
drupal-config_export_annotation-3132759-12.patch	1.95 KB
9.0.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply

Sorry for the clutter. It took me a while to find out that the error "trailing whitespace" actually means "windows line ending" which I forgot to change in my editor after a re-installation.

Comment #15

jungle

He/Him

Chongqing, China

CreditAttribution: jungle as a volunteer commented 26 November 2020 at 14:56

Status:

Needs review

» Needs work

+++ b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php
@@ -635,8 +635,11 @@ public function testToArraySchemaException() {
+      ->willReturn("Mock_ConfigEntityTypeInterface");
...
+    $this->expectExceptionMessage("Entity type 'Mock_ConfigEntityTypeInterface' is missing 'config_export' definition in its annotation");

The test is green, but in reality, it never throws error on specific Interface, it's against specific Class.

Let's change Mock_ConfigEntityTypeInterface to FooConfigEntity to make sense more

Comment #16

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented 26 November 2020 at 20:00

Status:

Needs work

» Needs review

File	Size
drupal-config_export_annotation-3132759-16.patch	1.92 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,443 pass 9.2.x: PHP 7.4 & MySQL 5.7 27,823 pass 9.1.x: PHP 7.4 & MySQL 5.7 27,819 pass
interdiff_13_16.txt	894 bytes

File

Size

drupal-config_export_annotation-3132759-16.patch

1.92 KB

9.0.x:
PHP 7.3 & MySQL 5.7 27,443 pass

9.2.x:
PHP 7.4 & MySQL 5.7 27,823 pass

9.1.x:
PHP 7.4 & MySQL 5.7 27,819 pass

interdiff_13_16.txt

894 bytes

Addressed #15

Comment #17

jungle

He/Him

Chongqing, China

CreditAttribution: jungle as a volunteer commented 26 November 2020 at 23:24

Status:

Needs review

» Reviewed & tested by the community

Thanks, it's ready to me.

Comment #18

jungle

He/Him

Chongqing, China

CreditAttribution: jungle as a volunteer commented 26 November 2020 at 23:25

Version:

9.0.x-dev

» 9.2.x-dev

Comment #19

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 8 December 2020 at 16:14

Version:	9.2.x-dev	» 9.1.x-dev
Component:	extension system	» configuration entity system
Status:	Reviewed & tested by the community	» Fixed

Committed and pushed b2519618b4 to 9.2.x and c8b93171c9 to 9.1.x. Thanks!

Comment #20

8 December 2020 at 16:15

alexpott committed b251961 on 9.2.x

Issue #3132759 by mvonfrie, AaronBauman, anmolgoyal74, jungle,...

Comment #21

8 December 2020 at 16:15

alexpott committed c8b9317 on 9.1.x

Issue #3132759 by mvonfrie, AaronBauman, anmolgoyal74, jungle,...

Comment #22

22 December 2020 at 16:19

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ConfigEntityType "missing 'config_export" error message doesn't say what annotation is missing

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community