Problem/Motivation

Turning on the cool editor tabs on a page using Layout builder shows a white circle for the Layout option

Steps to reproduce

Enable cool editor tabs
Navigate to a page that has layout builder (e.g. umami recipe page)
Result: white circle appears without an icon

Proposed resolution

Create an icon for layout and add to sprite

Comments

nvexler created an issue. See original summary.

  • Dennis Cohn committed e9ad4a7 on 1.0.x 
    Issue #3183613 by nvexler: layout builder tab equivalent has no icon (...
dennis cohn’s picture

dennis cohn commented

I've added a new icon to support the Layout Builder.
Please update the module to 1.0.2 to see the changes (maybe you need to clear the cache to see the new sprite).

dennis cohn’s picture

dennis cohn commented
Status: Active » Fixed
papagrande’s picture

papagrande
Primary language English
commented

@dennis-cohn, your quick turnaround is impressive!

Other core and contrib modules also add local tasks to node pages, e.g. content_translation and https://www.drupal.org/project/lingotek. Is there a generic icon (or three) that could show up?

dennis cohn’s picture

dennis cohn commented

A default icon as a fall back make sense to me, but what if some other/new contrib module adds another unknown local tab? Then we have 2 fallback icons?
Maybe it's better to show the first letter of the local tab for now? I should try to get a list of the most common local tabs and add icons for those.
I think we've covered 90% of all cases then.

In the future I hope to build a settings page where you can set the icons for the local tabs.
Translation is covered in this version of the module, btw.

Maybe it's good make a feature request so we can discuss it over there?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.