Problem/Motivation
The GDPR-Module is translatied 100 % to German again. But there is one string missing. its
That token could not be translated, because it will be skipped by the malformed HTML Filter in Core.
https://localize.drupal.org/translate/languages/de/translate?sid=1752228
We like to improve the translation Process a bit to make sure Modules in general can be translated to 100 % and only untranslated strings will be shown, when a new release is created. That is not possib le here, because if someone translates front in accident there will be an ui error trown again
Steps to reproduce
translate the string on l.d.o
wait until the file is renderd
updte translations for the module
see the error
Proposed resolution
remove the strng front from t() to make sure it will not be published on l.d.o, again
remove po-files for GDPR from l.d.o and rerender them afterwards.
Remaining tasks
See above
User interface changes
remove string from ui
API changes
none
Data model changes
none
Comments
Comment #2
jhodgdonI am not sure what the context is, but I don't think
<front>should probably be translated at all? It is probably something that needs to be typed in literally by an administrator to indicate the front page of the site, and it should not be translated into another language?What is the context for the string usage in the GDPR module?
Comment #3
james.williamsI think this might even have been filed under the wrong project too? https://localize.drupal.org/translate/projects/gdpr says German has been fully translated anyway. One of the instances of <front> that's been linked to in the issue summary here is from the https://www.drupal.org/project/eu_cookie_compliance project, so I'll move this ticket over there. It looks to me as though the string has been picked up because it is the initial config value in
eu_cookie_compliance.settingsunder the key 'popup_link', which is defined astype: labelin that configuration's schema definition. The label type makes the value translatable.So I'm not sure why this would be an issue. I would guess that it's entirely correct for different languages to use a different path for this link, but initially all languages default to using the home page - so I imagine it's correct for this string to be left unchanged in German/etc?
Comment #4
berdirThis is basically the same as the core issue about the frontpage: #2275865: Per language settings (vs translated settings) are not directly supported. Drupal core does not have a way to say that a config key is localizable, but not translatable text, meaning it should not be extracted with potx.
So considering that core does not support that, the correct thing for now would be to make that type: path, like the frontpage. But it might break existing sites that did localize this configuration setting.
Comment #5
svenryen commentedWe've had this report before, and concluded we couldn't remove it from translations, since users do want to translate the string once it's set. Would it be better if we used
/nodeas the default value?Comment #6
james.williamsI suspect the issue of an untranslated translatable string is better than shifting the burden to end users having to remember to change that setting if their homepage is not
/node?So I'd tentatively suggest closing this as 'Closed (won't fix)', as action is ultimately restricted by a limitation in Drupal core, as Berdir explained. As far as I can see, the 'bug' is just that a % on a dashboard of translated strings isn't 100, rather than an 'actual' issue that can affect end users?
Sorry if that doesn't recognise something about the nature of the issue!
Comment #7
svenryen commentedComment #8
joachim namysloI am sorry for opening that up in the wrong project folks. Did not even recognize that. Kudos to berdir for explaining this, anyway. I love that community. You are all great.
Thank you