Problem/Motivation

Add support for Drupal 9
Errors reported by Upgrade status (^3.0)

I decided to include in this patch (as reported bugs/tasks aka code cleanup) also:
#2871748: Convert module to use short array syntax (new coding standard).
#2871762: Clean up the codebase
#3003776: Apply new format for dependencies
#2866234: User error: "weight" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php)
#3135336: t() calls should be avoided in classes
#3148989: Automated Drupal 9 compatibility fixes

CommentFileSizeAuthor
#15 3181111-drupal-9-compatibility-15.patch25.36 KBa.sotirov
#14 3181111-drupal-9-compatibility-14.patch25.35 KBa.sotirov
#3 3181111-3.patch23.88 KBviappidu

Issue fork tagadelic-3181111

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

viappidu created an issue. See original summary.

viappidu’s picture

viappidu commented
Issue summary: View changes
viappidu’s picture

viappidu commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3181111-3.patch23.88 KB

Possibly messing up things a bit in including so many different patches but I was using all of them.
Made sense in this way (to me).

Apply correctly to dev version

I'm also updating the tracking issue for the D8 (D9 at this point) version.

viappidu opened merge request !1

viappidu closed merge request !1

viappidu reopened merge request !1

jollysolutions’s picture

jollysolutions
one/the
commented
Status: Needs review » Reviewed & tested by the community

Works well for me. Thank you

renguer0’s picture

renguer0 commented

So, it could be updated? :)

mvogel’s picture

mvogel commented

+1 for me as well.

Minor task, some test classes need to be updated from extending WebTestBase to BrowserTestBase

viappidu’s picture

viappidu commented

:)
Wouldn't be nice?
Though mainteners are not really into this...
But I really love this module and I resorted creating a patched git repository I can access directly from composer

"repositories": [
        {
            "type": "package",
            "package": {
                "name": "drupal/logintoboggan",
                "type": "drupal-module",
                "version": "master",
                "source": {
                "type": "git",
                "url": "ssh://XXXXXXXXXXXXXXXXXXXXXX",
                "reference": "master"
                }
            }
        },
        {....

I keep wondering if there are no (ready) easier/better Drupal 9 solutions as it seems the module is used only by few hundreds people...

viappidu’s picture

viappidu commented

PS obviously the package name above would be "drupal/tagadelic", not the only module I resorted fixing in this way...

renguer0’s picture

renguer0 commented

Maybe it could be forked because I don't see any activity here from a while.

Thanks for the patch @viappidu!

calbasi’s picture

calbasi
Primary language Catalan
Location Catalonia
commented

I think this module is well maintained:

https://www.drupal.org/project/tagclouds

Maybe it could be considered the d8/d9 version of the old Tagadelic ;-)

a.sotirov’s picture

a.sotirov commented
StatusFileSize
new 3181111-drupal-9-compatibility-14.patch25.35 KB

I just updated the proposed patch changes with project'stest issues fixes.

a.sotirov’s picture

a.sotirov commented
StatusFileSize
new 3181111-drupal-9-compatibility-15.patch25.36 KB

I've just updated the patch with some TagadelicList php notices fixes.

RumenDamyanov made their first commit to this issue’s fork.

AstonVictor made their first commit to this issue’s fork.

astonvictor’s picture

astonvictor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.