[meeting] Migrate Meeting 2020-11-05 [#3179679]

Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: https://www.drupal.org/project/drupal/issues/3179679. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues:

0️⃣ Who is here today? Besides COVID-19 and the US election, what is going on in the world? (I am hoping for some perspective from my non-US friends. Personal or global answers are welcome.)

dinarcon	:wave:
(anonymous)	Comment Redacted
benjifisher	I should set a good example and introduce myself: Benji, one of the co-maintainers of the core migration system. I have been distracted by the US elections this week.
quietone	Victoria, also migrate maintainer. Lots of spring rain here which makes me sad that I didn't get all the transplanting done in the winter.
benjifisher	Where I live, winter is coming but it is not here yet. We have a few sunny, warmer than usual days this week, but I stayed inside all day working. :disappointed: I think the good weather is supposed to stay through the weekend, though.
john.ouellet	:wave:
heddn	Hurricane Eta just came through and we're starting to dry out (edited)

1️⃣ What should we talk about today? Suggest topics here and I will add threads.

dinarcon	The meeting time. The summary says 2100 UTC. It is 2200 UTC at the moment. Should we update the meeting time?
quietone	I need to know what to do about the addition of an id to a comerce migrate source plugin, #3052488: Add field value migration to Ubercart 7 products
quietone	Need a new direction for an json api client for the json source plugin, #3150949: Add a migration source plugin for JSON:API#comment-13889210
john.ouellet	Should we chat about the views migration issue / initiative ?

2️⃣ Action items. To be added later.

benjifisher	Documentation: expand the page on migration_lookup with a complete example. Add a similar example (new page) for dom_migration_lookup. @benjifisher
benjifisher	Memory management: move #3000050: Replace \Drupal\Component\Utility\Environment::checkMemoryLimit with a PHP memory checking helper class and service forward. @benjifisher
benjifisher	NR: #2925899: MigrateUpgradeImportBatch does not use source_private_file_path & source_base_path correctly, making it impossible to have public & private files in separate locations @benjifisher
quietone	NW: #3052488: Add field value migration to Ubercart 7 products @quiteone

3️⃣ Statistics

benjifisher	Fixed since last week's meeting: none. :disappointed: (not counting issues for meetings)
benjifisher	Are the RTBC issues going to pile up until December, when 9.1.0 is released? Most of them now target 9.2.x, so I hope they can be committed. There are a couple of backports targeting 9.0.x: is there any hope for those?
benjifisher	RTBC: 11, including one Major.Two have not been touched in more than 2 months.
benjifisher	NR: 24, including 5 that have not been updated in more than a month. 4 are Major. Not a great state of affairs, but an improvement over last week.

4️⃣ Schedule

benjifisher	My mistake: the core calendar (link pinned to this channel) shows that this meeting alternates each week between 14:00 and 21:00 UTC. DST just ended where I live, so I am an hour late today.
dinarcon	I can meet either time, but with timezones changes at different rates across multiple countries, it would be nice to stick to UTC times. Updating the UTC meeting time is possible too.
benjifisher	I am calling it a mistake. I plan to stick to (or return to) what it says on the core calendar.

5️⃣ Documentation

benjifisher	@dinarcon: last week we discussed adding a complete example using the DOM process plugins. Would that be a good example for https://www.drupal.org/docs/drupal-apis/migrate-api/process-pipelines or do you think it should go under https://www.drupal.org/docs/8/api/migrate-api/migrate-process-plugins?
benjifisher	BTW, a few months ago I listed the process plugins from other core modules on https://www.drupal.org/docs/8/api/migrate-api/migrate-process-plugins/li.... Earlier this week, I thought, "there must be a process plugin that prepares values for a link field". I looked at my own list and found link_uri.
dinarcon	@benjifisher for the DOM example, I think it is worth having a dedicated page at https://www.drupal.org/docs/8/api/migrate-api/migrate-process-plugins In particular, because I suggest having a full working migration example, not just a snippet. That is, 2 complete migrations connected via the DOM lookup.
benjifisher	Oh, the DOM lookup. I am already planning to expand the page on migration_lookup in much the same way.

6️⃣ Move memory management from MigrateExecutable to an event subscriber

benjifisher	#3000050: Replace \Drupal\Component\Utility\Environment::checkMemoryLimit with a PHP memory checking helper class and service. Earlier today, I added a comment there. Maybe I can get some help here.
benjifisher	From #67:you cannot mock static methods for testingCan you explain this? Is this just in the context of getMockBuilder() or are you saying that I cannot doclass TestEnvironmentMemory extends EnvironmentMemory { ... }and override the static methods?
benjifisher	The current patch on #3006750: Move memory management from MigrateExecutable to an event subscriber adds the migrate.memory_manager service (class Drupal\migrate\MemoryManager), and we want to inject EnvironmentMemory (or, for testing purposes, a mock class) into its constructor. Is there a way to do the injection without making EnvironmentMemory a service?
quietone	For me, this is starting to feel like it needs a separate chat with interested parties to get it moving again.

7️⃣ [META] Drupal 7 to Drupal 8 Migration path

benjifisher	#2456259: [META] Drupal 7 to Drupal 8 Migration path
benjifisher	The two child issues that were NR after a reroll are now back to RTBC. :+1: That leaves #2925899: MigrateUpgradeImportBatch does not use source_private_file_path & source_base_path correctly, making it impossible to have public & private files in separate locations (edited)
quietone	:+1: (edited)

8️⃣ JSON:API

benjifisher	#3150949: Add a migration source plugin for JSON:API
benjifisher	@quietone, is this the part where you need help?Oh and I looked into using https://github.com/swisnl/json-api-client but was able to install it. It requires Guzzle 7 and core seems to require Guzzle 6.
quietone	Yes
benjifisher	I do not want to wait for D10. #3104353: Upgrade to Guzzle 7
benjifisher	I will ask again on the #contenta channel.
quietone	I don't want to wait either.
heddn	Since this is core, any new dependency has to be validated by release managers. So unless its a well known dependency with a track record of security support and a wide community support, it could be tough to use a json client. we're better off using symfony's json parsers and build all the pieces of this using things that already exist in drupal core

9️⃣ Add field value migration to Ubercart 7 products

benjifisher	#3052488: Add field value migration to Ubercart 7 products
quietone	The source plugin adds an id. Instead of deprecating this could just a a row to the existing map table. I think.
benjifisher	I think you mean a column. That should not be hard to do by implementing hook_update_N().
benjifisher	Ask the plugin manager for a list of migration plugins that use this source plugin. Then update the map tables. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...
quietone	Yes, I meant a column and using hook update.
quietone	Good idea to check for all plugins that use that source plugin. I didn't think of that.
benjifisher	I am not sure that the plugin system is available when update functions are run. If not, then I guess you can use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

1️⃣0️⃣ Wrap up.

benjifisher	Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.
benjifisher	If you can, please join us at 10:00 ET (15:00 UTC) tomorrow for the migration BoF at NEDCamp: https://nedcamp.org/node/404
quietone	@benjifisher, thank you for facilitating. I'll do the minutes this weekend.

Participants:

dinarcon, benjifisher, quietone, john.ouellet, heddn