Needs work
Project:
Drupal core
Version:
main
Component:
media system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Oct 2020 at 06:35 UTC
Updated:
18 May 2023 at 06:23 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
Oscaner commentedComment #3
Oscaner commentedReroll on Drupal 9.2.x
Comment #4
vsujeetkumar commentedThis patch needs Reroll, as it has changes in core/modules/media/js/plugins/drupalmedia/plugin.es6.js file.
Update es6 file then compile the code with yarn.
Comment #5
gauravvvv commentedRe-rolled patch #3, Attached interdiff for same. Please review.
Comment #6
gauravvvv commentedComment #7
yogeshmpawarRemoving Needs Reroll tag from the issue.
Comment #8
chetanbharambe commentedHi @Gauravmahlawat,
Verified and tested patch #5.
Patch applied successfully and looks good to me.
Testing Steps:
# Goto: Appearance -> Apply Seven theme
# Goto: Extend -> Install "Media Library" module
# Goto: admin/config/content/formats -> click on configure button in front of Full HTML
# Add the "Insert Media Library" button into the active toolbar
# Select "Double Click" from the drop-down which is under the dialog open mode.
# Check the checkbox for "Embed Media"
# Save Configuration
# After Saving the configuration, If the results are not showing correctly then try to uninstall the "Media Library" module and again Install it.
# Observe the results.
Expected Results:
# After applying patch #5, the User is able to double click on an inserted image to open EditorMediaDialog in CKEditor.
Actual Results:
# Currently, the User is not able to double click on inserted image to open EditorMediaDialog in CKEditor.
Please refer attached screenshots for the same.
Looks good to me.
Can be a move to +1RTBC.
Note: Patch #5 needs to be re-rolled because some custom commands are getting failed.
Comment #11
saman malik commentedVerified and tested patch #5 for version-9.4.x-dev.
Patch applied successfully and looks good to me.
Testing Steps:
1. Goto: Appearance -> Apply Seven theme
2. Goto: Extend -> Install "Media Library" module
3. Goto: admin/config/content/formats -> click on configure button in front of Full HTML
4. Add the "Insert Media Library" button to the active toolbar
5. Select "Double Click" from the drop-down which is under the open dialog mode.
6. Check the checkbox for "Embed Media"
7. Save Configuration
8.After Saving the configuration, If the results are not showing correctly then try to uninstall the "Media Library" module and again Install it.
Expected Results:
After applying patch #5, the User is able to double-click on an inserted image to open EditorMediaDialog in CKEditor.
Actual Results:
Currently, the User is not able to double-click on an inserted image to open EditorMediaDialog in CKEditor.
Comment #12
saman malik commentedComment #13
bnjmnm@Saman Malik The patch in #4 has custom commands failed in 9.4.x and doesn't apply to 9.5.x, that would need to be addressed before something can be RTBC.
@Everyone - how do screenshots demonstrate anything for this issue when it's the interaction that differentiates this from HEAD, not the dialog that is displayed?
I can understand wanting to add double clicking as a way to access media options to match the existing double clicking to access image options. However, this can't be the only means of accessing the options as it's not particularly useful for non pointer device uses cases such as screenreaders and touch devices.
This seems more like something that a contrib module could offer. I think this will be difficult to justify adding to core, particularly since CKEditor is deprecated in favor of CkEditor5. Additional development on deprecated modules (or plugins that extend them) typically needs to be bugfixes only.
Comment #14
saman malik commentedComment #16
burnellw_cit commentedComment #17
burnellw_cit commented