Problem/Motivation

Provides a configuration to allow user select how to open EditorMediaDialog in CKEditor.

image1.png

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Kang Miao created an issue. See original summary.

Oscaner’s picture

StatusFileSize
new10.07 KB
new117.57 KB
new84.44 KB

image2.png

image3.png

Oscaner’s picture

Version: 8.8.x-dev » 9.2.x-dev
StatusFileSize
new10.28 KB

Reroll on Drupal 9.2.x

vsujeetkumar’s picture

Issue tags: +Needs reroll

This patch needs Reroll, as it has changes in core/modules/media/js/plugins/drupalmedia/plugin.es6.js file.

Update es6 file then compile the code with yarn.

gauravvvv’s picture

StatusFileSize
new10.13 KB
new3.8 KB

Re-rolled patch #3, Attached interdiff for same. Please review.

gauravvvv’s picture

Status: Needs work » Needs review
yogeshmpawar’s picture

Issue tags: -Needs reroll

Removing Needs Reroll tag from the issue.

chetanbharambe’s picture

StatusFileSize
new432.57 KB
new391.6 KB
new427.08 KB

Hi @Gauravmahlawat,
Verified and tested patch #5.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Appearance -> Apply Seven theme
# Goto: Extend -> Install "Media Library" module
# Goto: admin/config/content/formats -> click on configure button in front of Full HTML
# Add the "Insert Media Library" button into the active toolbar
# Select "Double Click" from the drop-down which is under the dialog open mode.
# Check the checkbox for "Embed Media"
# Save Configuration
# After Saving the configuration, If the results are not showing correctly then try to uninstall the "Media Library" module and again Install it.
# Observe the results.

Expected Results:
# After applying patch #5, the User is able to double click on an inserted image to open EditorMediaDialog in CKEditor.

Actual Results:
# Currently, the User is not able to double click on inserted image to open EditorMediaDialog in CKEditor.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to +1RTBC.

Note: Patch #5 needs to be re-rolled because some custom commands are getting failed.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

saman malik’s picture

Assigned: Unassigned » saman malik
StatusFileSize
new356.17 KB
new324.85 KB

Verified and tested patch #5 for version-9.4.x-dev.
Patch applied successfully and looks good to me.
Testing Steps:
1. Goto: Appearance -> Apply Seven theme
2. Goto: Extend -> Install "Media Library" module
3. Goto: admin/config/content/formats -> click on configure button in front of Full HTML
4. Add the "Insert Media Library" button to the active toolbar
5. Select "Double Click" from the drop-down which is under the open dialog mode.
6. Check the checkbox for "Embed Media"
7. Save Configuration
8.After Saving the configuration, If the results are not showing correctly then try to uninstall the "Media Library" module and again Install it.
Expected Results:
After applying patch #5, the User is able to double-click on an inserted image to open EditorMediaDialog in CKEditor.

Actual Results:
Currently, the User is not able to double-click on an inserted image to open EditorMediaDialog in CKEditor.

saman malik’s picture

Status: Needs review » Reviewed & tested by the community
bnjmnm’s picture

Status: Reviewed & tested by the community » Needs work

@Saman Malik The patch in #4 has custom commands failed in 9.4.x and doesn't apply to 9.5.x, that would need to be addressed before something can be RTBC.

@Everyone - how do screenshots demonstrate anything for this issue when it's the interaction that differentiates this from HEAD, not the dialog that is displayed?

I can understand wanting to add double clicking as a way to access media options to match the existing double clicking to access image options. However, this can't be the only means of accessing the options as it's not particularly useful for non pointer device uses cases such as screenreaders and touch devices.

This seems more like something that a contrib module could offer. I think this will be difficult to justify adding to core, particularly since CKEditor is deprecated in favor of CkEditor5. Additional development on deprecated modules (or plugins that extend them) typically needs to be bugfixes only.

saman malik’s picture

Assigned: saman malik » Unassigned

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

burnellw_cit’s picture

StatusFileSize
new10.14 KB
burnellw_cit’s picture

StatusFileSize
new10.73 KB

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.