Problem/Motivation
The following translations are de facto untranslatable because they are containing <ace> :
https://localize.drupal.org/translate/languages/de/translate?project=ace...
The reason for this is, that Drupal's malformed html filter skips strings with unallowed / unknown tags. So the strings containing the <ace> are de facto untranslatable, because even if we translate them to any language importing will be skiped.
therefore whenever a regular opening tag or closeing is used iin ui text it should be replaced with html entities..
Steps to reproduce
Proposed resolution
use html entities instead of opening and closing tags in translation source strings containing the <ace> tag.
Remaining tasks
change UI translation strings
User interface changes
Change texts so that thexy will be translateaböe without using a legion of html tidy tools to figure out waht's wrong here..
API changes
none
Data model changes
none
Issue fork ace_editor-3177428
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
joachim namysloComment #3
joachim namysloComment #4
joachim namysloComment #5
joachim namysloComment #6
joachim namysloMaybe this could be solved by useing html entities for special chars in translation. So
shold become
We are currently testing this here: https://localize.drupal.org/translate/languages/de/translate?sid=2670460
If it gets rendered in 30 minutes or so we'll all know if this could be a proper solution to get ace editors translation thowards 100 %
Second test with an ace-Edditor String: https://localize.drupal.org/translate/languages/de/translate?sid=1136378
Comment #7
joachim namysloSeems to be ok now, at least for 8 and 9 No errors anymore when HTML entities are used. Can't even find the affected text in the ui anymore. So I was not able to cross check this with my own eyes. HTML-Tidy must be enough so far.
Comment #8
joachim namysloComment #9
joachim namysloComment #10
joachim namysloNeeds to be reviewed in Varbase 8 and 9 for example. Maybe even simpletest. Me with German translation enabled will be enough.
Comment #11
rajab natshahNeeds an updated issue fork and MR for the
2.0.xbranch.Comment #12
rajab natshahComment #14
rajab natshahComment #16
rajab natshahMerged as aeb33d5 via !18 — the tags now arrive as placeholders, so the translatable string carries no HTML at all.
Comment #18
rajab natshah✅ Released ace_editor-2.0.4