Problem/Motivation

The module just doesn't work with structures that have terms with the same names in a vocabulary, even if their position in the tree is on a completely different branch. Also multi-parent terms are not supported at all.

Steps to reproduce

Try to export and import taxonomies where terms in the tree have the same names or have multiple parents.

Proposed resolution

  1. Use UUID instead of name when checking if a term exists in a vocabulary.
  2. Apply tree structure after all the terms are imported, not during import.
CommentFileSizeAuthor
#2 structure_sync-multi-name-parent-support-3177106-2.patch16.07 KBgraber

Issue fork structure_sync-3177106

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Graber created an issue. See original summary.

graber’s picture

graber commented
Status: Active » Needs review
StatusFileSize
new structure_sync-multi-name-parent-support-3177106-2.patch16.07 KB
graber’s picture

graber commented
Assigned: graber » Unassigned
Issue summary: View changes

Updated issue description a bit so it carries some basic information now.

steelstrung’s picture

steelstrung commented
Priority: Normal » Major

I think the priority on this one should be higher - Structure Sync doesn't provide mcuh value if it won't import the whole taxonomy in this common scenario.

steelstrung’s picture

steelstrung commented
Status: Needs review » Needs work

Patch test failed

graber’s picture

graber commented

3 years ago it worked 😂 wish I remembered the project it was for.
Looks like maintainers missed this.

wolcen’s picture

wolcen commented

Looks like this proposed solution includes some client-specific code:

+            if ($taxonomy['name'] == 'Residency' && $taxonomy['vid'] == 'campaign_goal') {
+              $parent_terms = $storage->loadByProperties(['uuid' => $parent_uuids]);
+            }

mparker17 made their first commit to this issue’s fork.