Closed (fixed)
Project:
Flood control
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Oct 2020 at 19:17 UTC
Updated:
24 Dec 2020 at 12:34 UTC
Jump to comment: Most recent
As discussed in #1845626: Provide UI to remove blocks from flood it would be a good idea to merge the Flood Unblock (https://www.drupal.org/project/flood_unblock) and Flood Control modules.
- Incorporate all the functionality of Flood Unblock in Flood Control.
- Incorporate all the functionality of Flood Unblock in Flood Control.
A table will be added that allows users to delete items from the flood table.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
wim leers+1, it's really confusing right now to figure out which module to use when. Even more confusingly, @fabianderijk seems to maintain both! :D
So … @fabianderijk, could you update both project pages to describe when to use which module, or ideally, merge the two modules?
Comment #3
fabianderijk@Wim,
I do maintain both, but only since a short while including
flood_control. We (@batigolix and me) ar maintainers of theflood_unblockmodule. We came across the flood_control module a while ago. I even already asked to co-maintain or incorporate the two modules a few years ago without any response.A few weeks / months ago we revitalised the
flood_unblockmodule and started the progress to actually become co-maintainer for theflood_controlmodule with the idea to eventually integrate theflood_unblockmodule into it. Functionality of both modules are not the same, but extending each other and should be placed in one module. And because we think Flood Control is a better name for the functionality, we are moving everything to this module and are deprecating theflood_unblockmodule.FYI, @batigolix and I have discussed a exiting strategy for
flood_unblockwhere we will warn existing users to start using theflood_controlmodule when the functionality has been moved.Comment #4
batigolixComment #6
batigolixPlease review MR 2
All the functionality from Flood Unblock has been moved to Flood Control
You cannot have both modules installed at the same time.
Comment #8
batigolix