Report changed service name path.alias_manager => path_alias.manager

Hi,

I run into same problem, and it is very difficult to find out which module is causing this.

@anoopjohn reported the same at #3220409: Upgrade Status module did not catch changed service name path.alias_manager => path_alias.manager

This should be possible in phpstan-drupal. Opened https://github.com/mglaman/phpstan-drupal/issues/192

EDIT: drupal-rector catches a bit of this, but not all cases, so only a little bit of inspiration to find there.

FYI, I just did a quick search in one project and found occurrences in the paragraphs_report Drupal module.

palantirnet/drupal-rector catches Drupal::service() calls, but it apparently does not catch arguments to services and retrieving the service from the container. Below is code from paragraphs_report:

services:
  # Expose class as service and pass in config.
  paragraphs_report.report:
    class: Drupal\paragraphs_report\ParagraphsReport
    arguments:
      - '@config.factory'
      - '@entity_field.manager'
      - '@entity_type.manager'
      - '@path.current'
      - '@path.alias_manager'

  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('config.factory'),
      $container->get('entity_field.manager'),
      $container->get('entity_type.manager'),
      $container->get('path.current'),
      $container->get('path.alias_manager'),

+1
I faced this too, where deprecated service usage in Global calls to \Drupal::service('path.alias_manager') are not being called deprecated.

Deprecations will be reported if you use:

$container->get()
\Drupal::getContainer->get()

The following issue will fix \Drupal::service() calls

https://github.com/mglaman/phpstan-drupal/issues/190

I'll update the issue when it's available to test

The fix for \Drupal::service calls has been added to phpstan-drupal:0.12.15, which should provide all the required coverage for detecting the access of deprecated services.

Can you please run a Composer update to get the latest phpstan-drupal version and verify? If so, we can bump the minimum version for upgrade_status.

Thanks @mglaman. This should fix it for Upgrade Status once people do a composer update.