Problem/Motivation

Checkboxes other webform type which are marked "required" are now requiring the first checkbox be checked even if there are multiple checkboxes. Validation reads "Please check this checkbox if you want to proceed."

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3174229-4.patch1.22 KBjrockowitz
#3 3174229-3.patch1.62 KBjrockowitz
#2 webform.webform.issue_3174229.yml5.16 KBjrockowitz
#2 3174229-2.patch943 bytesjrockowitz

Comments

drupalizedinoc created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3174229-2.patch943 bytes
new webform.webform.issue_3174229.yml5.16 KB

The attached webform replicate the required issue with the clientside_validation.module for the checkboxes other elements.

The attached patch fixes this issue.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3174229-3.patch1.62 KB

I also noticed that clicking the back button caused the checkboxes validation not be setup correctly.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3174229-4.patch1.22 KB

  • jrockowitz authored dbdb349 on 8.x-5.x 
    Issue #3174229 by jrockowitz: Checkboxes, Checkboxes Other
jrockowitz’s picture

jrockowitz commented

I committed the patch. Please download the latest dev release to review.

  • jrockowitz authored dbdb349 on 6.x 
    Issue #3174229 by jrockowitz: Checkboxes, Checkboxes Other
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
cbfannin’s picture

cbfannin commented

I had this issue and installed latest dev for review as suggested and seems to be working fine for me now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented

The issue is not yet fixed.
Though the patch is added the issue still exists and is replicable.

kaise.lafrai’s picture

kaise.lafrai commented

@jrockowitz This issue is the closest I could find that resembles the issue I am having with the checkboxes-other element.

I have a 'checkboxes other" element with multiple options to select from. The field is required. If I select "other" and no other checkboxes and leave the text field that appears empty and select NEXT, the inline error messages appear twice, once for the entire element and once for the "other" text field that was left empty. What I was expecting to happen is that the overall error message would not appear since I did select an option from the checkboxes (in this case I chose "other"). I am thinking we need to add additional logic to the webform.states.js to trigger the event handler only if "other" is selected and the text field is left empty.

Thank you for looking into this issue.