call_user_func_array() and named arguments in PHP 8

I came across this same issue in core or contrib (can't remember exactly where) and the fix was the same. This is again a change in PHP 8.0 behaviour.

I remember now. It was in this drush related project: https://github.com/consolidation/annotated-command/pull/210/files

Interesting, if phpstan can catch such cases, going to check if other places needs this fix

+++ b/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php
@@ -97,7 +97,7 @@ public function doTrustedCallback(callable $callback, array $args, $message, $er
 
-    return call_user_func_array($callback, $args);
+    return call_user_func_array($callback, array_values($args));
   }
 

Should we add comments to these cases explaining why the array_values() is necessary?

Should we add comments to these cases explaining why the array_values() is necessary?

I don't think it's very necessary to do that. This is going to be a PHP 8 effect and it shouldn't be too hard to check why is call_user_func_array with array_values a common pattern. But I'd go with the consensus here.

++ to 10, there's git history for that

Added todo and follow-up #3174150: Discuss use of named arguments in Renderer::doCallback()

It needs research pro/contra but at least this place now documented

Moving back to RTBC as the change is only a comment.

Committed ba28c93 and pushed to 9.1.x. Thanks!