Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Sep 2020 at 15:06 UTC
Updated:
12 May 2022 at 09:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mgiffordShould we do the same with assistive technology like NVDA & VoiceOver?
Comment #3
mherchelComment #4
volkswagenchickAdded child issues for individual browser testing. WIll add issues as they are created, thanks.
Comment #5
volkswagenchickComment #6
thejimbirch commentedStill need to determine what functions will need to be tested.
Will there be different things to test on mobile and desktop browsers?
Comment #7
mherchelComment #8
thejimbirch commentedThread from Drupal slack: https://drupal.slack.com/archives/CJT807H7T/p1632752290045700?thread_ts=...
If a maintainer did request this, could they advise or provide guidance? TIA!
Comment #9
mherchelAdding testing script
Comment #10
mherchelupdating summary
Comment #11
proeungThe following browser QA issues have been tested, reviewed, and listed as fixed.
#3210745: QA testing of Olivero - Desktop browser: Google Chrome
#3210751: QA testing of Olivero - Desktop browser: Internet Explorer
#3210752: QA testing of Olivero - Mobile browser: UC Browser
Comment #12
catchBartik and Seven were added during the major development cycle (i.e. before minor releases and experimental), and then there were issues like #2152519: [meta] Make sure Drupal 8 looks good and works right on browsers (both mobile+desktop) to retrospectively test them before release.
Umami is perma-experimental so there hasn't been a step where it's marked stable.
Claro isn't stable yet.
So Olivero is the first new core theme to go from experimental to stable in any meaningful way, meaning we don't have any clear precedents.
My personal feeling here is that there's been a lot of informal testing of Olivero on multiple browsers, and some of that could have been documented on this issue earlier in the process, to save having to retest everything at the end - even if that might not have meant a formal script run-through probably would have been enough. Having said that can't have too much testing.
Comment #13
mherchelComment #14
gábor hojtsyParenting to making it the default now.
Comment #15
andypostComment #17
sk33lz commentedI found an issue on the Olivero test site where the progress percentage displays directly next to the progress message within AJAX progress and AJAX small progress with no spacing between the text and the percentage. I initially noticed this while testing the progress bars doing QA on Safari, but I also verified the same issue exists on all browsers I've tested. This includes browsers marked as fully tested with their QA issues closed, so posting here. This particular issue exists in the latest versions of Safari, Chrome, Firefox, IE 11, Edge, and Brave, so I would have to say it's across the board. See the attached screenshot taken on a desktop screen at 1080P.
Comment #18
gábor hojtsyComment #19
mherchelOpened followup #3277557: Olivero: Progress indicator percentage label does not have proper spacing for #17. Thanks @sk33lz!
Comment #20
lauriiiAll issues from the roadmap have been closed!
Comment #21
lauriiiComment #22
phjouI added a comment on the Firefox one earlier, it is very difficult to read the search placeholder for me:
https://www.drupal.org/project/drupal/issues/3210746
Should I create a specific issue?
Comment #23
catch@phjou yes please create a new issue!