Problem/Motivation

$ phpcs --standard=Drupal .

FILE: /login_destination/src/Controller/LoginDestinationListBuilder.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
 50 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-----------------------------------------------------------------------------------------------------------------------


FILE: /login_destination/src/LoginDestinationManagerInterface.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 21 | ERROR | Description for the @return value is missing
-----------------------------------------------------------------------------------------------------------------


FILE: /login_destination/src/Form/LoginDestinationSettingsForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------
 16 | ERROR | Missing short description in doc comment
 23 | ERROR | Missing short description in doc comment
 30 | ERROR | Missing short description in doc comment
 51 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------------------------


FILE:/login_destination/src/Form/LoginDestinationRuleForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------
 107 | ERROR   | [x] Short array syntax must be used to define arrays
 109 | ERROR   | [x] Short array syntax must be used to define arrays
 127 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
 178 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 248 | ERROR   | [ ] Description for the @return value is missing
 277 | ERROR   | [x] Object operator not indented correctly; expected 8 spaces but found 10
 280 | ERROR   | [x] Short array syntax must be used to define arrays
 312 | ERROR   | [x] Comment indentation error after @todo element, expected 3 spaces
-------------------------------------------------------------------------------------------------------------------------------


FILE: /login_destination/src/LoginDestinationInterface.php
-------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
  47 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 113 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------


FILE: /login_destination/src/LoginDestinationManager.php
--------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------
 102 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 108 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 115 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 120 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 125 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 132 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 139 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 146 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 174 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
 174 | ERROR   | [x] Comments may not appear after statements
 191 | ERROR   | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------------------------------


FILE: /login_destination/tests/src/Functional/UrlParameterTest.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 22 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------

Proposed resolution

Fix the errors as per Drupal coding standards.

User interface changes

NONE

API changes

NONE

Data model changes

NONE

CommentFileSizeAuthor
#2 3172398-2.patch10.38 KBankithashetty

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

Status: Active » Needs review
StatusFileSize
new10.38 KB

Made the required changes as per the Drupal coding standard in the following patch file, kindly review.

Thank you!

rsvelko’s picture

Status: Needs review » Fixed

Committed! Thanks for the patch.

  • rsvelko committed 17434b5 on 8.x-2.x
    Revert "Issue #3172398 by ankithashetty: Fix Drupal Coding Standard...

  • rsvelko committed d74f2ae on 8.x-2.x
    Revert "Revert "Issue #3172398 by ankithashetty: Fix Drupal Coding...
rsvelko’s picture

Ignore last 2 commits. They cancel each other out.

  • rsvelko committed c03f9b1 on 8.x-2.x
    Issue #3172398 by rsvelko: Fix Drupal Coding Standard Errors: fix 2 more...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.