Closed (fixed)
Project:
Views Selective Filters
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2020 at 17:43 UTC
Updated:
28 Dec 2021 at 04:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
elamanHere is the patch with the fix.
Comment #3
elamanComment #4
mmjvb commentedIt is removing support for older versions of D8. The core key should remain or document support for ^8.7.7.
Comment #5
ankithashettyUpdated the patch with the suggestions recommended by @mmjvb in #4... Kindly review.
Thanks!
Comment #6
elaman@mmjvb quote from Specifying the core_version_requirement when needed
Current version of the Drupal 8 core is way past 8.7.7. So you must remove core from info file. Un-updated Drupal website shouldn't be accounted for.
Patch #5 will throw exceptions.
Comment #7
mmjvb commentedThat quote is about ^8.8 || ^9, not ^8 || ^9 !!!
Patch #5 looks good to me, should not throw exceptions. The quote actually says when having both it MUST be ^8||^9 as in patch #5.
Agree that both the implementation and documentation on core_version_requirement is confusing.
The removal of the core key is not related to the current version of Drupal core (9.0.6). You should remove that key when no longer supporting installation of the module on core before 8.7.7. Removing it forces the upgrade to at least core 8.7.7 or even higher depending on core_version_requirement.
When removing the core key, using ^8||^9 no longer makes sense! Suggest to use ^8.7.7 || ^9 instead.
Consider removing core key scope creep of this issue. This issue should mention the removal of support for core before 8.7.7 if that is what is intended. Also this change doesn't add support for D9, it allows installation and use on D9. Support for D9 would be ensuring no D8 deprecated code is used.
Comment #8
gaurav.kapoor commentedThis has been fixed in recent commits.
Comment #9
mmjvb commentedComment #11
gaurav.kapoor commentedGood catch @mmjvb. I didn't release the 'core' key was still set in the info.yml file. I have removed it in another commit.
Comment #12
gaurav.kapoor commentedThe info.yml looks good to me now.