Problem/Motivation
If version cookie doesn't exist, some use cases do want to retrigger the popup.
Steps to reproduce
- Agree to to cookie policy before the module has the Cookie Policy Version feature #2987584: Terms version change (GDPR regulation)
- Update to a module version which has that feature
- Surf to the website again and notice you won't have to re-agree, while some use cases would like this
Proposed resolution
We removed:
if (typeof Drupal.eu_cookie_compliance.getVersion() === 'undefined') {
// If version doesn't exist as a cookie, set it to the current one.
// For modules that update to this, it prevents needless retriggering
// For first time runs, it makes no difference as the other IF statements
// below will still cause the popup to trigger
// For incrementing the version, it also makes no difference as either it's
// a returning user and will have a version set, or it's a new user and
// the other checks will trigger it.
Drupal.eu_cookie_compliance.setVersion();
}
But it'd probably better to keep that as default behaviour and introduce a setting to skip this behaviour.
Remaining tasks
Patch, test, ...
User interface changes
Yes. Configuration option addition.
API changes
None.
Data model changes
None.
Comments
Comment #2
pieterdcComment #3
svenryen commentedI see the point. We'll try to get this into 1.x before we start 2.x.
Comment #4
svenryen commentedComment #5
reszliI ran into the same use-case, where I needed to retrigger the popup for users who already expressed consent on the old version (without categories)
attached patch (against 8.x-1.19) works for me
Comment #6
svenryen commentedThanks for the patch. We'll get this into the next verison.
Comment #7
svenryen commentedComment #9
svenryen commentedCommitted, thanks for the contribution!