Problem/Motivation

While working on several other patches/issues I stumbled across several bits of code I wanted to clean up, but none of the changes fit within the other patches or were big enough issues to warrant their own, so I'm bundling them all here (patches will follow).

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

RTBC & merge

User interface changes

None.

API changes

  1. Renamed the misspelled 'TablefieldFormatter::$ModuleHandler' to the expected 'TablefieldFormatter::$moduleHandler'
  2. Removed the default value of the unused property '#add_row'

Data model changes

N/A

CommentFileSizeAuthor
#7 clean-code-deprecated-dynamic-property-3170043-7.patch787 bytesdylan donkersgoed
#5 clean-code-deprecated-dynamic-property-3170043-5.patch1.74 KBchuyenlv
#3 3170043-code-cleanup--remove-unused-property-3.patch344 bytess.abbott
#3 3170043-code-cleanup--fix-indentation-3.patch549 bytess.abbott
#3 3170043-code-cleanup--fix-capitalization-3.patch1.29 KBs.abbott
#3 3170043-code-cleanup--add-return-documentation-3.patch555 bytess.abbott
#2 xxx-code-cleanup--remove-unused-property-2.patch344 bytess.abbott
#2 xxx-code-cleanup--fix-indentation-2.patch549 bytess.abbott
#2 xxx-code-cleanup--fix-capitalization-2.patch1.29 KBs.abbott
xxx-code-cleanup--add-return-documentation-2.patch555 bytess.abbott

Issue fork tablefield-3170043

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

s.abbott created an issue. See original summary.

s.abbott’s picture

s.abbott commented
StatusFileSize
new xxx-code-cleanup--fix-capitalization-2.patch1.29 KB
new xxx-code-cleanup--fix-indentation-2.patch549 bytes
new xxx-code-cleanup--remove-unused-property-2.patch344 bytes
s.abbott’s picture

s.abbott commented
StatusFileSize
new 3170043-code-cleanup--add-return-documentation-3.patch555 bytes
new 3170043-code-cleanup--fix-capitalization-3.patch1.29 KB
new 3170043-code-cleanup--fix-indentation-3.patch549 bytes
new 3170043-code-cleanup--remove-unused-property-3.patch344 bytes

Forgot to rename the files to include the issue #! Reuploading with correct name (contents are identical).

s.abbott’s picture

s.abbott commented
Status: Active » Needs review
chuyenlv’s picture

chuyenlv commented
StatusFileSize
new clean-code-deprecated-dynamic-property-3170043-5.patch1.74 KB

Tested with Drupal 10 and I see some errors:
- Deprecated function: Creation of dynamic property Drupal\tablefield\Plugin\Field\FieldFormatter\TablefieldFormatter::$ModuleHandler is deprecated
- Deprecated function: Creation of dynamic property Drupal\tablefield\TableValue::$value is deprecated
I create the patch to fix these errors.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

Thanks for the patch comment 5, it solved the warnings.

dylan donkersgoed’s picture

dylan donkersgoed commented
StatusFileSize
new clean-code-deprecated-dynamic-property-3170043-7.patch787 bytes

The clean-code-deprecated-dynamic-property-3170043-5.patch patch no longer applies to the latest dev/2.5-rc1 versions because the moduleHandler property name has been fixed. Attaching a new patch which includes only the setValue fix.

erutan made their first commit to this issue’s fork.

erutan changed the visibility of the branch 8.x-2.x to hidden.

erutan opened merge request !26

  • erutan committed eb087153 on 8.x-2.x 
    Issue #3170043 by s.abbott, chuyenlv, dylan donkersgoed: Code cleanup
erutan’s picture

erutan commented
Title: Code cleanup » Code cleanup, including deprecated function: Creation of dynamic property
Status: Needs review » Fixed

Patch #7 applies cleanly to dev / RC2 and solves the issue. This is the most important patch,

The following two patches have already been implemented:

3170043-code-cleanup--fix-indentation-3.patch
3170043-code-cleanup--fix-capitalization-3.patch

The following patch applies cleanly:

3170043-code-cleanup--add-return-documentation-3.patch

The following patch has been confirmed that there is no add_row property and applies cleanly:

3170043-code-cleanup--remove-unused-property-3.patch

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Should this be cherry-picked onto branch 3.0.x?

erutan’s picture

erutan commented

The bugfix should be universally applied, the code cleanup is trivial but universal. It'd be nice to not have future patches have to deal with it (the capitalization of moduleHandler was fixed at least 3 times in different patches). It should be in both branches.

  • liam morland committed fea05d62 on 3.0.x authored by erutan 
    Issue #3170043 by s.abbott, chuyenlv, dylan donkersgoed: Code cleanup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.