Drupal 9 is here. Please merge https://www.drupal.org/project/acl/issues/3160344 and then publish a new release so we can run ACL on drupal 9.

Comments

xeM8VfDh created an issue. See original summary.

salvis’s picture

salvis
he/his
commented

Do we really need a D9 release? I thought the core_version_requirement was enough for running on D9.

I hesitate to create a new release because D8 has never seen a green test yet...

xem8vfdh’s picture

xem8vfdh commented

Thanks for checking in Salvis. I believe the answer is yes, we need to cut a new release that includes the latest core_version_requirement and other d9 changes. My site is running the latest ACL, and when I upgraded to 9 I was informed that ACL was incompatible and I had to remove it to prevent my site from breaking.

While these latest D9 fixes are in the dev branch, they are not in the latest alpha2 release, whose info file reads:

name: ACL
type: module
description: 'Access control list API. Has no features on its own.'
core: 8.x
package: 'Access control'

# Information added by Drupal.org packaging script on 2019-09-23
version: '8.x-1.0-alpha2'
project: 'acl'
datestamp: 1569227888

This is the problem.

xem8vfdh’s picture

xem8vfdh commented
Related issues: +#3083015: ACL for D8 — ALPHA2
salvis’s picture

salvis
he/his
commented

Thank you for your private message, xeM8VfDh.

My testing suggests that the latest release of ACL is incompatible with D9
because the changes required to make it D9 compatible have been committed to
the project after the last release was published

Indeed, ACL is not even compatible with D8, since the testbot comes back red.

The red test is our indicator that ACL is not working, and as long as we can't get it to turn green, it makes no sense to create a new release. You may as well patch it locally in your installation to fake your desired state.

xem8vfdh’s picture

xem8vfdh commented

Alternatively, despite the red indicator, ACL is working sufficiently on my D8 installation, and would on my D9 installation if a new release were published. The red indicator is a reflection of the testing state, which is hugely helpful but, at the end of the day, is purely hypothetical (as opposed to the real functional value that I am enjoying on my existing D8 site). While I can definitely patch this myself, I'd imagine many users aren't that tech savvy. Consequently, foregoing a real-world solution for a hypothetical red indicator seems somewhat shortsighted to me.

In short, despite imperfection, this module is providing value to live sites that shouldn't be held back from updating, especially when the level of imperfection when running on D8 is no different than the level of imperfection when running on D9.

I hope that's not too critical, just my $0.02.

xem8vfdh’s picture

xem8vfdh commented

hey @salvis, thoughts?

salvis’s picture

salvis
he/his
commented

I see your point, but a red release is not an option. We'd have to remove the failing test and put up a big warning that migration is probably not working.

Is the test wrong or the migration code? I'm really frustrated that no one can fix this!

xem8vfdh’s picture

xem8vfdh commented

Hey @salvis, thanks for the response. I totally understand your concern here as well. Is there a specific contributor I should contact about resolving the issue you mentioned? I may be able to look into it personally, but I'll admit I am totally out of the loop as the whats going on. Is there a separate issue tracking the failing tests/migration?

xem8vfdh’s picture

xem8vfdh commented

@salvis, Drupal 9 is losing support in 10 months. Is there any chance you'd reconsider, or should all D8 sites using ACL abandon it if they want to move to D9?

bogdog400’s picture

bogdog400 commented

@salvis -- Thanks very much for your hard work on this.

I'm building out a new site that needs ACL. It also requires D9. It would be very helpful if I can use ACL and not roll my own.

Is there any way I can help with this?

xem8vfdh’s picture

xem8vfdh commented

awesome @bogdog400! Hopefully we can get the ball rolling on this :)

salvis’s picture

salvis
he/his
commented

After #3191157: Get tests passing, do we need any further changes for D9 before creating a new release?

xem8vfdh’s picture

xem8vfdh commented

I don't think so, as long as this is included: https://www.drupal.org/project/acl/issues/3160344

Thanks @salvis!

salvis’s picture

salvis
he/his
commented
Status: Active » Fixed

We have #3199241: ACL for D8 and D9 — BETA1.

Thank you bogdog400 for offering your help. Please let us know how it goes according to #3199241: ACL for D8 and D9 — BETA1.

xem8vfdh’s picture

xem8vfdh commented
Status: Fixed » Active

thanks @salvis 🥳🥳🥳

bogdog400’s picture

bogdog400 commented

I tried the module a bit this afternoon on a clean install. My only problems were caused by the Field Permissions module.

If I see anything else, I'll let you know.

Thanks!

xem8vfdh’s picture

xem8vfdh commented

I just did some minor testing on my existing D9 site (converted from D8), and it seems to be working without issue.

salvis’s picture

salvis
he/his
commented
Status: Active » Fixed

Thank you for the fast feedback!

My only problems were caused by the Field Permissions module.

Is there something that ACL should/could do about it? (This would have to go into a new issue...)

bogdog400’s picture

bogdog400 commented

I can't imagine what you might do about Field Permissions. In my case, it just got to the edit page first and overrode anything here. But once I disabled it, things behaved as expected.

I suppose a long-term solution might be to merge the two modules. Perhaps.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.