Problem/Motivation

It seems that after upgrading to 6x version. jquery_ui_checkboxradio was not added as a requirement and throws error jquery_ui_checkboxradio (Missing)

Steps to reproduce

Upgrade from webform 5.19 to 6@alpha15

Proposed resolution

I added jquery_ui_checkboxradio to my composer file as a dependency to solve the issue. It should probably be added to the webform composer file just like jquery_ui and jquery_ui_tabs.

CommentFileSizeAuthor
#6 3169815-6.patch499 bytesjrockowitz

Comments

jedgar1mx created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Closed (won't fix)

jquery_ui_checkboxradio is only required for the deprecated webform_jqueryui_buttons.module. I do not want to force every site to download this dependency. There is no immediate solution.

One long term solution would be moving all the webform submodules into dedicated projects, but this approach could become unmanageable for me to maintain.

jedgar1mx’s picture

jedgar1mx commented

Yes, I totally agree in not forcing download of a dependency. Maybe just adding a note or warning for people that look to upgrade from 5x to 6x and use the deprecated module.

rajab natshah’s picture

rajab natshah
he/him
commented

Thank you Jacob for the dedicated nice work on the Webform module.
Thank you Edgar for the notice issue.

I had a testing round with
#3168739: Update [Webform] module from ~5.0 to ~6.0
Many thanks for supporting Drupal 9

I do think a composer suggestion will be good enough. 
  "suggest": {
    "drupal/jquery_ui_checkboxradio": "~1.0:  This module provides the jQuery UI checkboxradio library for any themes and modules that require it. Needed for the webform_jqueryui_buttons module if you are using the module. It is not recommended to depend on jQuery UI in your own code, and instead to select a replacement solution as soon as possible.",
  },

Still I do think that is too much in the composer suggest.

The messing message at the Extend page is good too, with more description help for the webform_jqueryui_buttons module as an example.

Thank you :)

jrockowitz’s picture

jrockowitz commented
Status: Closed (won't fix) » Needs work

I think adding "suggest" to the composer.json file is good idea.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed
StatusFileSize
new 3169815-6.patch499 bytes

  • 1a0400d committed on 6.x 
    Issue #3169815: jquery_ui_checkboxradio (Missing)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.