Problem/Motivation

Requested by Razem
Provided by Yasmeen

https://github.com/Vardot/varbase_layout_builder/pull/2

When we open any Layout Builder Modal or the Media Library
They do not look themed in the right way to look like Claro
But they look like the Seven admin theme

Proposed resolution

Disable Media Library Reset theme module
Style the Editorial Modal to look like Claro admin theme

Remaining tasks

  • Commit the pull request
  • Have a full testing round on components
  • Round #2 optimization for Varbase Layout Builder

User interface changes

Claro admin theme look for all Layout Builder Modal

API changes

N/A

Data model changes

N/A

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

mohammed j. razem’s picture

I was thinking of this enhancement and we need to make sure of the following:

  • Add a hook update to make sure Claro theme is enabled. Because older Varbase sites might not have Claro enabled, and this will potentially break.
  • Add an if statement to check if Claro theme is enabled in VarbaseLayoutBuilderThemeNegotiater
  • Add Drupal version requirement to the Varbase Layout Builder. We need to make sure we're using Drupal core when it actually has the Claro theme in core.

This will ensure a fault tolerant implementation, so when older Varbase sites update to the most recent version of Varbase Layout Builder, and their config still uses the older Vartheme Adminimal, they can still use these feature effectively.

  • RajabNatshah committed ec6f1a5 on 8.x-1.x
    Issue #3169416: Round no. 2 optimization for [Varbase Layout Builder]...
rajab natshah’s picture

rajab@vardot-dev:/var/www/html/products/varbase_layout_builder$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_layout_builder/ --ignore=/var/www/html/products/varbase_layout_builder/node_modules/
rajab@vardot-dev:/var/www/html/products/varbase_layout_builder$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_layout_builder/ --ignore=/var/www/html/products/varbase_layout_builder/node_modules/

  • RajabNatshah committed 7f77a1c on 8.x-1.x
    Issue #3169416: Round no. 2 optimization for [Varbase Layout Builder]...

  • RajabNatshah committed cae1305 on 8.x-1.x
    Issue #3169416: Round no. 2 optimization for [Varbase Layout Builder]...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: -varbase +varbase-8.8.7, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
yasmeensalah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.