Closed (fixed)
Project:
Upgrade Status
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
1 Sep 2020 at 16:04 UTC
Updated:
17 Sep 2020 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gábor hojtsyAccesTest and AnalyzeTest pass with this patch. Unfortunately AnalyzeTest has a hack as I did not yet figure out why the submodules with error not showing up.
Comment #3
gábor hojtsyAutomated updates I wish. Tests.
Comment #4
gábor hojtsyThis should fix all the tests. The following are included altogether:
1. Base test now checks boxes based on their new form locations grouped by status.
2. (1) made it possible to remove the status check method in UiTest since it would be checking the same thing.
3. Fixed in project collector that one of the submodule tests were improperly grouped.
4. Fixed the library exception test module info file to have a unique module label.
5. Fixed the export method in the form to traverse the form in the new structure properly. Refactored the HTML/text export so it does not try to set a NULL Symfony response object in case nothing was selected.
6. Added project row classes and scan result classes to result table to support scan result UI testing.
7. Made the "Not scanned" and the "No results after scan" cases distinct in the scan result display. This is tested for.
8. Fixed scan result controller to use the new correct value to figure out if the project is contrib or custom.
9. Updated the analyze test to remove the json_decode()s, we are not storing JSON double encoded anymore.
10. Updated the UI test to test with the new CSS selectors and the new result summary numbers.
All passes locally :)
Comment #5
gábor hojtsyI think there is normally an option to run testing of a patch even if the branch test fails, but did not find it, so will commit this and then look at the branch test. Fingers crossed.
Comment #7
gábor hojtsyComment #9
gábor hojtsy@Kristen Pol also found the export fails in #3165529: Various feedback on 8.x-3.x, points 5 and 6. Crediting her as well.