This is my cosmetic concern about the source code --- Let's align the format of 'key' = $value to the longest key, which is field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com", Note that 'field_image_upload_url' should be 'field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com", removing redundant extra one space.
Comments
Comment #2
jigish.addweb commentedComment #3
jigish.addweb commentedComment #4
yasThis is my cosmetic concern about the source code --- Let's align the format of
'key' = $valueto the longest key, which isfield_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com",Note that'field_image_upload_url'should be'field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com", removing redundant extra one space.Comment #5
jigish.addweb commentedComment #6
jigish.addweb commented@yas Thank you for your review.
I have done changes as per your comment. Please review the updated patch.
Thanks
Comment #7
yas@jigishaddweb
Thank you for the update. It looks good to me. I'll merge the patch to
8.x-2.xand3.xand close this issue asFixed.Comment #10
yas