Problem/Motivation

There doesn't seem to be test coverage for what happens to non-product content on the site as part of the migration.

Steps to reproduce

Run the Commerce v1 migration on Commerce Kickstart v2.

Proposed resolution

Add test coverage to ensure the non-product content is migrated properly

New test added, NodeTest that has assertions for some non product fields and terms.
Added field value assertions to ProductTest and ProductVariation test.

Remaining tasks

  • Write test coverage for the non-product nodes.
  • Write test coverage for the non-product terms.
  • Review

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#13 3166734-13.patch30.78 KBquietone
#13 interdiff-11-13.txt2.15 KBquietone
#11 3166734-11.patch30.75 KBquietone
#11 interdiff-8-11.txt4.83 KBquietone
#6 3166734-8.patch29.66 KBquietone
#6 interdiff-6-8.txt2.2 KBquietone
#5 3166734-6.patch29.05 KBquietone
#5 interdiff-4-6.txt2.32 KBquietone
#4 3166734-4.patch29.7 KBquietone
#4 interdiff-2-4.txt11.61 KBquietone
#2 3166734-2.patch23.12 KBquietone

Issue fork commerce_migrate-3166734

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3166734-2.patch23.12 KB

This adds a test of migrating nodes including testing field values. A field value test is also added to ProductTest and ProductVariationTest

Status: Needs review » Needs work

The last submitted patch, 2: 3166734-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt11.61 KB
new 3166734-4.patch29.7 KB

I thought I ran ProductTest locally. Anyway, in order to test field value it needs to run more migrations, so those are added. I also added a helper method to Commerce1TestBase that creates dummy files.

quietone’s picture

quietone commented
StatusFileSize
new interdiff-4-6.txt2.32 KB
new 3166734-6.patch29.05 KB

Just cleaning up.

quietone’s picture

quietone commented
StatusFileSize
new interdiff-6-8.txt2.2 KB
new 3166734-8.patch29.66 KB

Now add assertions for non-product terms to the new NodeTest. I think that covers everything in the IS.

Anything more to do here?

quietone’s picture

quietone commented
Issue summary: View changes

  • quietone committed 5684f4d on 8.x-2.x 
    Issue #3166734 by quietone: Add test coverage for Commerce v1 non-...

  • quietone committed dd1d28f on 8.x-2.x 
    Revert "Issue #3166734 by quietone: Add test coverage for Commerce v1...
quietone’s picture

quietone commented

Reverted because tests fail with postgresql.

quietone’s picture

quietone commented
StatusFileSize
new interdiff-8-11.txt4.83 KB
new 3166734-11.patch30.75 KB

I don't think the order of the field value matters, so just change the test to order the values by target_id.

quietone’s picture

quietone commented

I am testing with postgres locally and the tests pass.

quietone’s picture

quietone commented
StatusFileSize
new interdiff-11-13.txt2.15 KB
new 3166734-13.patch30.78 KB

Some improvements but still can't get a failure locally.

quietone opened merge request !1

quietone’s picture

quietone commented

That is better. I think this is ready to commit.

  • quietone committed d6fab3d on 8.x-2.x 
    Issue #3166734 by quietone: Add test coverage for Commerce v1 non-...
quietone’s picture

quietone commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.