Problem/Motivation

Quick Edit link doesn't generate correctly for Results, Build and Settings buttons if a Webform machine name begin with "test".

Steps to reproduce

  1. Install/Enable Webform and Quick Edit
  2. Create Webform with Title "Test Case Issue Form" should have machine name (test_case_issue_form) and add any elements
  3. View Webform "Test Case Issue Form" (/form/test-case-issue-form)
  4. Note the quick edit button shows 4 links
    • Test (/form/test-case-issue-form?_webform_test=test_case_issue_form)
    • Results (/form/test-case-issue-form?_webform_test=manage)
    • Build (/form/test-case-issue-form?_webform_test=manage)
    • Settings (/form/test-case-issue-form?_webform_test=manage)

Proposed resolution

Improve regex to check for /test at end of the URL string within webform.contextual.js. Adding End of String character ($) resolves this issue patch is attached.

CommentFileSizeAuthor
quick-edit-regex-improvement.patch499 bytesTechnorange

Comments

Technorange created an issue. See original summary.

Technorange’s picture

Status: Active » Needs review

  • Technorange authored 31bb66c on 8.x-5.x
    Issue #3166146 by Technorange: Quick Edit link doesn't generate...
jrockowitz’s picture

Status: Needs review » Fixed

Thanks for the patch.

  • Technorange authored 31bb66c on 6.x
    Issue #3166146 by Technorange: Quick Edit link doesn't generate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.