Problem/Motivation

When saving settings on the /admin/config/user-interface/easy-breadcrumb page, the lists of words ignored or forced by the capitalizator are lost breaking the functionality.

Steps to reproduce

Visit /admin/config/user-interface/easy-breadcrumb
Enter 'and a of the' to the list of words ignored by the capitalizator in the advanced settings.
Save the settings.
Observe that the list entered has been removed
Observe that capitalisation exists on all words as the list has been removed from config

Proposed resolution

When saving the input 'and a of the', it must be converted and stored in config as an array rather than as a string. There is an existing processValuesToArray function in the general settings form that looks like it was designed for the job, but it is not used anywhere. This function should be used to process the input value prior to saving.

When this setting was converted from a string to an array, an update hook should have been employed. Updating the module from a version that stored the config as a string to a version that stores the config as an array breaks the functionality. Marking this as requires work for an update hook to be added to convert words list config on existing installs.

Comments

AlanHDev created an issue. See original summary.

alanhdev’s picture

Patch supplied that should apply cleanly to 8.x-1.13 and 8.x-1.x-dev

alanhdev’s picture

StatusFileSize
new949 bytes

Updated patch to apply to the forced words settings too.

alanhdev’s picture

Title: Capitalizator ignored words list lost on settings save » Capitalizator ignored and saved words list lost on settings save
Issue summary: View changes
Status: Active » Needs work
alanhdev’s picture

Assigned: alanhdev » Unassigned
greg boggs’s picture

looks good

rachelf’s picture

Yes, works for me too.

neslee canil pinto’s picture

Status: Needs work » Reviewed & tested by the community

+1 Looks good to me as well. Marking has RTBC.

neslee canil pinto’s picture

Status: Reviewed & tested by the community » Fixed

Committed to dev branch. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.