On php7.2 bootstrap_rijkshuisstijl_preprocess_page produces a count() error:

count(): Parameter must be an array or an object that implements Countable

CommentFileSizeAuthor
#2 count-php72-error-3165190-2.patch640 bytesbatigolix

Comments

batigolix created an issue. See original summary.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Needs review
StatusFileSize
new count-php72-error-3165190-2.patch640 bytes

This can be fixed by checking if the parameter is an array.

Status: Needs review » Needs work

The last submitted patch, 2: count-php72-error-3165190-2.patch, failed testing. View results

bryandenijs’s picture

bryandenijs
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Yes, it's a good idea to check it first. Nice fix!

  • batigolix committed 2cbbcf8 on 8.x-1.x 
    Issue #3165190 by batigolix, BryanDeNijs: php 7.2 count error
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Fixed
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented

Made a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.