| tedbow |
Ted, working on core Auto Updates, Acquia. NY, USA |
| Bhavin Joshi (he/him) |
Bhavin Joshi, Rajkot, GJ, India (edited) |
| hestenet (he/him) |
Tim Lehnen, with the DA - (he/him) - Clackamas and Multnomah Chinook lands in Porltand, OR. Organizing the meeting thread today :slightly_smiling_face: |
| dts |
I'm here. Hello! |
| drumm |
:wave: going to work on the server side implementation |
| xjm |
:wave: A bit late. was working on PHP-TUF at like 5:00a so just woke from a nap. :slightly_smiling_face: |
| eiriksm |
eirik, interested in auto updates, from norway |
| hestenet (he/him) |
@xjm raised these interrelated issues. |
| hestenet (he/him) |
Would any one like to step forward on release notes and change record drafting? |
| Bhavin Joshi (he/him) |
I would like to take this up after I complete testing PSA to core |
| Bhavin Joshi (he/him) |
However, I would appreciate if anyone else also collaborates with me. (edited) |
| hestenet (he/him) |
Thank you for offering to draft some release notes/change record info @Bhavin Joshi (he/him)! That's awesome.I think after you are able to create an initial draft - @greg.1.anderson or @tedbow can validate that all the details are correct for you. |
| Bhavin Joshi (he/him) |
Sure. |
| greg.1.anderson |
@Bhavin Joshi (he/him) Just @-mention me when you have a draft, and I will review. Or LMK if you have questions before then. |
| Bhavin Joshi (he/him) |
Certainly @greg.1.anderson! Thank you! :handshake: |
| dts |
We could certainly run the checks at install time for the files being updated. |
| tedbow |
oh I meant when first install the auto_updates module. we don’t run the readiness checks that come with the module |
| dts |
As for Composer, some readiness checks are much harder. We can't create a mapping from a package archive file to how the package will look on disk after installation. |
| dts |
Ah, yes. It would be good to do an initial readiness run post-install. |
| dts |
Not sure how fast they run, though. |
| Bhavin Joshi (he/him) |
About the size on the disk, the module should provide an approximate value. Like: It may take upto YYMB space on your disk (edited) |
| tedbow |
I was wondering in the contrib module why we don’t run the Readiness Checks when the module is first installed.If there is a reason we should probably follow this for modules that installed after that have new Checkers |
| tedbow |
@heddn not around so I will post on the issue. maybe @dts knows? |
| dts |
I'm reading the d.o issue right now |
| hestenet (he/him) |
I believe @heddn may be out for the whole week - so may not be able to chime in until next week. |
| dts |
The issue thread is a little more than I can digest real-time as part of this meeting, though. Is the question about when to run readiness checks posted in the public issue? (edited) |
| tedbow |
I will update it. I will look thru the original contrib issue #3043521 |
| hestenet (he/him) |
@tedbow Raised this issue. |
| tedbow |
I was wondering in the contrib module why we don’t run the Readiness Checks when the module is first installed.If there is a reason we should probably follow this for modules that installed after that have new Checkers |
| tedbow |
@heddn not around so I will post on the issue. maybe @dts knows? |
| dts |
I'm reading the d.o issue right now |
| hestenet (he/him) |
I believe @heddn may be out for the whole week - so may not be able to chime in until next week. |
| dts |
The issue thread is a little more than I can digest real-time as part of this meeting, though. Is the question about when to run readiness checks posted in the public issue? (edited) |
| tedbow |
I will update it. I will look thru the original contrib issue #3043521 |
| tedbow |
#3043521: [META] Update readiness checks for autoupdate (pre-flight check) |
| tedbow |
the only reason I could think why the contrib wouldn’t be running the checks on install is that it might take too long. (edited) |
| dts |
We could certainly run the checks at install time for the files being updated. |
| tedbow |
oh I meant when first install the auto_updates module. we don’t run the readiness checks that come with the module |
| dts |
As for Composer, some readiness checks are much harder. We can't create a mapping from a package archive file to how the package will look on disk after installation. |
| dts |
Ah, yes. It would be good to do an initial readiness run post-install. |
| dts |
Not sure how fast they run, though. |
| Bhavin Joshi (he/him) |
About the size on the disk, the module should provide an approximate value. Like: It may take upto YYMB space on your disk (edited) |
| dts |
I'll be attending. Happy to assist on whatever others are working on (client or server). |
| tedbow |
I will be attending. working o the client application |
| drumm |
I should attend, more likely in the second half, but I can make the entire time work if there’s something specific to collaborate on. |
| Bhavin Joshi (he/him) |
I will try to attend it. It would be around 2300 hours here |
| xjm |
I'll be there, providing review and maintainability improvements for the client and docs :slightly_smiling_face: |
| mbaynton |
I work too much, so I might show up if I feel like not working on real work. :laughing: |
| tedbow |
@Bhavin Joshi (he/him) ok thanks |
| tedbow |
I guess my only concern is that if code you first post has many improvement iterations since you first copied the code from the contrib module it will be harder for the contrib maintainers of original code to tell what all the changes are and review those.versus posting the initial ported code and then iterating on the issue.it is just that the contrib presumable has been running on sites in production. |
| Bhavin Joshi (he/him) |
Understood. @tedbowI will post the updated code as soon as I am at my desk on Thursday. Tomorrow is holiday. |
| tedbow |
ok. great. thanks for the work on this! |
| tedbow |
enjoy the holiday! |
| Bhavin Joshi (he/him) |
Thank you. :slightly_smiling_face: |
| hestenet (he/him) |
@tedbow raised this topic. |
| hestenet (he/him) |
There is a potential cross over with this core ideas issue, about making a generic system for posting alerts/announcements - #2940739: Project messaging channel in core initiative - but that probably should not block this - just something to bear in mind. (edited) |
| Bhavin Joshi (he/him) |
All the required code are accomodated to core and I need to perform an extensive testing before I ask community to test it |
| hestenet (he/him) |
Excellent! |
| tedbow |
@Bhavin Joshi (he/him) did you start with the functionality in contrib module? |
| Bhavin Joshi (he/him) |
Yes, I did. |
| tedbow |
if you want to post it and I can also help review and write tests |
| hestenet (he/him) |
@tedbow raised this topic. |
| hestenet (he/him) |
There is a potential cross over with this core ideas issue, about making a generic system for posting alerts/announcements - #2940739: Project messaging channel in core initiative - but that probably should not block this - just something to bear in mind. (edited) |
| Bhavin Joshi (he/him) |
All the required code are accomodated to core and I need to perform an extensive testing before I ask community to test it |
| hestenet (he/him) |
Excellent! |
| tedbow |
@Bhavin Joshi (he/him) did you start with the functionality in contrib module? |
| Bhavin Joshi (he/him) |
Yes, I did. |
| tedbow |
if you want to post it and I can also help review and write tests |
| Bhavin Joshi (he/him) |
About 2940739, PSA can serve as an alert system 'in' a Drupal site. And as per 2940739, it can be public and accessible to everyone (edited) |
| Bhavin Joshi (he/him) |
@tedbow Yes, I am in the middle of it and I am going share the updated code after I have finished testing to my satisfaction. :slightly_smiling_face: |
| tedbow |
@Bhavin Joshi (he/him) ok thanks |
| tedbow |
I guess my only concern is that if code you first post has many improvement iterations since you first copied the code from the contrib module it will be harder for the contrib maintainers of original code to tell what all the changes are and review those.versus posting the initial ported code and then iterating on the issue.it is just that the contrib presumable has been running on sites in production. |
| Bhavin Joshi (he/him) |
Understood. @tedbowI will post the updated code as soon as I am at my desk on Thursday. Tomorrow is holiday. |
| tedbow |
ok. great. thanks for the work on this! |
| tedbow |
enjoy the holiday! |
| Bhavin Joshi (he/him) |
Thank you. :slightly_smiling_face: |
tedbow, Bhavin Joshi (he/him), hestenet (he/him), dts, drumm, xjm, eiriksm, greg.1.anderson, mbaynton
Comments
Comment #2
dstolComment #3
xjmThe meeting schedule has changed, so the next meeting is now Aug. 11. Updating accordingly.
Comment #4
xjmComment #5
xjmComment #6
xjmComment #7
xjmComment #8
xjmComment #9
xjmComment #17
dstolComment #18
beautifulmindHi @dstol,
For the record, I attended the meeting. (Bhavin Joshi)
Regards.
Comment #19
dstolComment #20
dstolComment #21
dstolSorry about that, I just dropped the participants list into the issue credit. I didn't realize your Slack name and your d.o name were different.
You should be credited now.
Comment #22
beautifulmindThank you very much for the quick update.
I apologies for the trouble caused by the different names. I just corrected it.
Regards.