Problem/Motivation

We want to be sure focus is absolutely visible in every possible permutation in Claro
This needs to be confirmed before Claro can be considered stable.

Steps to evaluate

Find every possible place where an item can be focused in Claro. Confirm the focus state is visible in desktop, mobile, and high-contrast modes (IE/Edge and Firefox).

Proposed resolution

This doesn't have to be done all at once, but anything that gets evaluated should be documented here so the work isn't repeated unnecessarily. If issues are found, they should be opened as child issues of this one.

Remaining tasks

Evaluate
Add issues as needed on each section:

Must haves

Should haves

Could haves

User interface changes

API changes

Data model changes

Release notes snippet

Comments

bnjmnm created an issue. See original summary.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue tags: +NorthAmerica2021, +Easy Out of the Box

Adding NorthAmerica2021 and Easy Out of the Box tags for visibility.

DrupalCon NA is April 12-16 with a focus on EOOTB on Wednesday, April 14.
Thanks

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +wcag247

Adding success criteria tag.

abowman’s picture

abowman commented

I've started a Google spreadsheet to track testing results for this: https://docs.google.com/spreadsheets/d/1ncIFdSJCddRVUGULD3pU-lTQkVy5rfFy...

First tab has instructions (work in progress), then second tab is for 9.2.x results (each test run in a given browser/device should have its own column). If/when Claro moves to a new minor version, we can create a new tab.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

aastrong’s picture

aastrong commented

I can likely help with some work on this one.
Would i add patches in this ticket?

Or would there be new tickets according to the assessment?

aastrong’s picture

aastrong commented

Nevermind, i understand now :)
I will help contribute to the assessment - add to, or create a new version of the document.

But let me know where I could create patches for the focus issues found.
I'm new to the Claro issue queue.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Thanks for your interest @aastrong!

But let me know where I could create patches for the focus issues found.

Head to the main Drupal core issues page at https://www.drupal.org/project/issues/drupal and click "Create a new issue". You can reference the metadata of this issue for what to fill out there (set Component to "Claro theme", etc). Make sure to set the "parent issue" to this one - type in the title or paste the URL to trigger the autocomplete on that field.

In addition to creating issues when problems are found, it's equally (perhaps more!) valuable to document where you've reviewed and found no problems - that way nobody repeats steps you've already taken. Something like

  • Pages Checked: (list of pages)
  • Browsers Used: (list of browsers)
  • Widths checked: (whatever mobile/desktop widths checked)
  • Windows High Contrast Browsers Checked: (Firefox and IE/Edge are the ones that would need checking)
  • Review method: (this may just be "tabbed through whole page to confirm focus visible", there might be additional steps for pages with interactive elements)

You alone definitely don't have to test every scenario - and letting us know what has been done already means others in the community can assist in completing the review.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Related issues: +#3270230: Toolbar focus styles are not sufficiently obvious to know where your focus is

I will add https://www.drupal.org/project/drupal/issues/3270230 as a related issue. It already has a parent issue therefor I am unable to assign it as child and also the scope for that issue isn't limited to Claro but to the toolbar.module in general. But the issue is of relevance and applies to Claro.

baddysonja’s picture

baddysonja
Primary language Icelandic
Location Frankfurt am Main
commented

At DrupalCon Portland 2022. Helped with testing mobile on 9.4.x https://docs.google.com/spreadsheets/d/1ncIFdSJCddRVUGULD3pU-lTQkVy5rfFy...

ckrina credited lauriii.

ckrina credited nerdstein.

ckrina credited tedbow.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
katannshaw’s picture

katannshaw commented

At DrupalCon Portland 2022. Just finished testing IE + high contrast mode on 9.4.x. Everything looks great! https://docs.google.com/spreadsheets/d/1ncIFdSJCddRVUGULD3pU-lTQkVy5rfFy...

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Active » Reviewed & tested by the community

We've reviewed the Focus Visible with the following browser and setting combinations:

  • Chrome + Desktop
  • IE - High Contrast
  • Edge - High Contrast
  • Chrome - High Contrast
  • Mobile
  • "Safari 13.1.2 MacOS High Sierra"

All the issues we've found weren't Claro issues (meaning they already existed in Seven) and already had issues:

Thanks everybody that helped testing this!

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

lauriii credited DyanneNova.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Portland2022

I've been collaborating with @DyanneNova, @baddysonja, @katannshaw, @ckrina, @nerdstein, and @tedbow at DrupalCon 2022 to do this assessment. The results were documented on the spreadsheet linked on #5. Some pre-existing core issues were discovered and issues were filed for those. Since there weren't any new Claro specific issues discovered, marking this as done.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

+1 on setting this to fixed. This baseline evaluation is more than thorough enough to confirm Claro is easily as good (and arguably much better) than Seven regarding focus visibility. There may be edge cases that show up on occasion, but the issue queue is sufficient for that. This meta has served it's purpose to confirm Claro provides good focus visibility for everyday use cases and beyond. Were this meta to remain open, it would largely exist to sadden those who want to see Claro land in Drupal. From this point forward, send those focus visibility issues to the regular old issue queue!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.