Problem/Motivation

In order to help a user know what each modules does and other type of information, I believe it will be helpful to have the link for the project page in the project name.

Proposed resolution

Add a link to the project page in the project name that exists in the form.

CommentFileSizeAuthor
#7 fix-for-attribute-3163522-7.patch564 bytesnsalves
#2 add-link-to-label-3163522-2.patch1.02 KBnsalves

Comments

Nelson Alves created an issue. See original summary.

nsalves’s picture

nsalves commented
StatusFileSize
new add-link-to-label-3163522-2.patch1.02 KB
nsalves’s picture

nsalves commented
Priority: Minor » Normal
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Currently it is a "label for" element, which means when you click it it will check the checkbox. Now that would only be true for custom projects. Not sure that is a good idea. Did you try the 8.x-3.x branch where it has an issue queue link even if there was no Drupal 9 plan information?

nsalves’s picture

nsalves commented

Hi Gábor
Thank you for your reply. Yes, I used the 8.x-3.x branch to build the patch (although I just checked that the patch no longer works since it seems some changes were made).
I checked and when the user clicks on the project name the checkbox don't becomes checked so this don't seem to interfere with that (or maybe I didn't understand your point).
I think the issue queue link serves a different purpose since it links to the issue queue and not the project main page which is the feature this patch tries to address. If you believe there's value adding this link I can submit a new version against the current version of the dev branch. Anyway thanks for your reply and apologies if I made any mistake in this process (first time committing a patch).

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, if clicking on the label does not check the box that is definitely a bug then. That is the whole point of making it a label element and the for attribute data provided below. It may become incorrect with the reshuffling of the elements.

See https://stackoverflow.com/questions/18432376/what-does-for-attribute-do-...

The <label> tag allows you to click on the label, and it will be treated like clicking on the associated input element.

nsalves’s picture

nsalves commented
StatusFileSize
new fix-for-attribute-3163522-7.patch564 bytes

After your explanation I went back to the code and the problem appears to be related with an error on the name of the for attribute. It should be the same as the id of the checkbox element to work as you explained. Here's a patch to fix that. With this fix the feature I suggested no longer makes sense. Thank you.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Link for the project page in the project name » Incorrect label for id attribute on 3.x branch
Category: Feature request » Bug report
Status: Needs review » Needs work

That is the direction indeed that we need to go IMHO to fix what was already working before. The group is not always relax though, this part of the ID needs to be dynamic.

  • Gábor Hojtsy committed bcbe6e2 on 8.x-3.x 
    Issue #3163522 by Nelson Alves, Gábor Hojtsy: Incorrect label for id...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Fixed

Committed an extended fix that passes on the machine name of the next step. Thanks!

Gábor Hojtsy credited Kristen Pol.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@Kristen Pol also found this in #3165529: Various feedback on 8.x-3.x, crediting her too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.