Problem/Motivation

Since symfony/http-foundation 5.1: The "Symfony\Component\HttpFoundation\Response::create()" method is deprecated, use "new Drupal\Core\Render\HtmlResponse()" instead.


    1x in ManyPlaceholderTest::testManyNoJsPlaceHolders from Drupal\Tests\big_pipe\Unit\Render

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff_4-6.txt718 bytesravi.shankar
#6 3161992-6.patch2.49 KBravi.shankar
#4 interdiff-2-4.txt720 byteshardik_patel_12
#4 3161992-4.patch2.49 KBhardik_patel_12
#2 3161992.patch1.64 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3161992.patch1.64 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

There is a third case that looks like it needs changing too:

core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php
1256:    $collection_response = ResourceResponse::create($merged_document);
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3161992-4.patch2.49 KB
new interdiff-2-4.txt720 bytes

Changing in core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php file also , kindly review.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work 
+++ b/core/modules/big_pipe/tests/src/Unit/Render/ManyPlaceholderTest.php
@@ -31,7 +31,7 @@ public function testManyNoJsPlaceHolders() {
+    $response = new BigPipeResponse(new HtmlResponse);

I think this should be new HtmlResponse() as per coding standards.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3161992-6.patch2.49 KB
new interdiff_4-6.txt718 bytes

Here this patch might fix comment #5.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.1.x-dev » 9.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 91ffbf84e7 to 9.1.x and 87f5ac8935 to 9.0.x. Thanks!

Backported to 9.0.x to keep the tests aligned as this only touches tests.

  • alexpott committed 91ffbf8 on 9.1.x 
    Issue #3161992 by Hardik_Patel_12, ravi.shankar, catch, longwave: Since...

  • alexpott committed 87f5ac8 on 9.0.x 
    Issue #3161992 by Hardik_Patel_12, ravi.shankar, catch, longwave: Since...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.