Annotation checking missing: context to context_definition and new config_export

Can you copy here what exactly would need to be detected?

Good point, parenting to the missing coverage issue. We don't currently check annotations I believe. We could add a very basic / crude check for this specific annotations. Are you aware of other annotations that would need to be checked?

Updated issue summary. Brought in config_export annotation report from #3131063: Detect GetResponseForExceptionEvent is deprecated in favour of ExceptionEvent.

All right, I have a pull request for phpstan-drupal to add a rule that will catch this: https://github.com/mglaman/phpstan-drupal/pull/186

EDIT: this is only for `context` to `context_definitions`

This handles config_export https://github.com/mglaman/phpstan-drupal/pull/188

I am still puzzled by branch switching with MRs. Did the following to get a fresh upgrade status checkout so I don't break my other dev checkouts:

$ git clone git@git.drupal.org:project/upgrade_status.git

Cloning into 'upgrade_status'...
remote: Enumerating objects: 302, done.
remote: Counting objects: 100% (302/302), done.
remote: Compressing objects: 100% (154/154), done.
remote: Total 2657 (delta 155), reused 266 (delta 120), pack-reused 2355
Receiving objects: 100% (2657/2657), 594.72 KiB | 746.00 KiB/s, done.
Resolving deltas: 100% (1649/1649), done.

$ cd upgrade_status

Did the following as per the above docs:

$ git remote add upgrade_status-3161052 git@git.drupal.org:issue/upgrade_status-3161052.git

$ git fetch upgrade_status-3161052

remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (3/3), 1.15 KiB | 294.00 KiB/s, done.
From git.drupal.org:issue/upgrade_status-3161052
 * [new branch]      3161052-annotation-checking-missing -> upgrade_status-3161052/3161052-annotation-checking-missing
 * [new branch]      5.x-1.x    -> upgrade_status-3161052/5.x-1.x
 * [new branch]      6.x-1.x    -> upgrade_status-3161052/6.x-1.x
 * [new branch]      7.x-1.x    -> upgrade_status-3161052/7.x-1.x
 * [new branch]      8.x-1.x    -> upgrade_status-3161052/8.x-1.x
 * [new branch]      8.x-2.x    -> upgrade_status-3161052/8.x-2.x
 * [new branch]      8.x-3.x    -> upgrade_status-3161052/8.x-3.x

Checked out 3161052-annotation-checking-missing:

$ git checkout 3161052-annotation-checking-missing
Branch '3161052-annotation-checking-missing' set up to track remote branch '3161052-annotation-checking-missing' from 'upgrade_status-3161052'.
Switched to a new branch '3161052-annotation-checking-missing'

Attempted to rebase to 8.x-3.x:

$ git rebase 8.x-3.x

Auto-merging src/DeprecationAnalyzer.php
CONFLICT (content): Merge conflict in src/DeprecationAnalyzer.php
error: could not apply 099f4e5... Issue #3151995 by Gábor Hojtsy, rohnjeynolds, siramsay, JD_1, maxilein, Arno2Mars, scrumorg, Arngrim: Log PHPStan error in project results to let people know it failed. Fix undefined errors index
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 099f4e5... Issue #3151995 by Gábor Hojtsy, rohnjeynolds, siramsay, JD_1, maxilein, Arno2Mars, scrumorg, Arngrim: Log PHPStan error in project results to let people know it failed. Fix undefined errors index

I fixed this conflict manually, then:

$ git add src/DeprecationAnalyzer.php 
$ git rebase --continue                                  

Auto-merging upgrade_status.install
Auto-merging upgrade_status.info.yml
CONFLICT (content): Merge conflict in upgrade_status.info.yml
error: could not apply c16e35b... Cannot install this module on Drupal 9: InfoParserException, undo semi-support for Drupal 9 for now
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply c16e35b... Cannot install this module on Drupal 9: InfoParserException, undo semi-support for Drupal 9 for now

Then this goes on forever, I stopped after a dozen or so manual conflict resolutions with the info file, the form, the deprecation analyzer (repeatedly on the same context lines multiple times).

What am I doing absolutely wrong here? This must not be the advertised to be super-easy MR workflow :D I am trying to get this one line composer.json change to rebase on top of the current 8.x-3.x.

@Gábor Hojtsy I skipped the rebase fanciness and just made a new branch for the change

We probably should add some kind of test in upgrade_status, maybe?

It just need to change to 4 failures I guess

Could be that fails are related to #3224167: Parameter excludes_analyse is deprecated. I committed that now. How do I send this MR to retest?

I did not find a way to send the MR to retest, so going to post the change in a patch.

Beginning of a test.

Further fixing of the tests.

Contrib item shows up first alphabetically and now they have the same amount of problems.

0 based indexing.

Of course its a warning, not an error because there is no version number involved.

Missed one spot.

In #3224393: Parameters excludes_analyse and excludePaths cannot be used at the same time, @Eric_A noted another reason to update to mglaman/phpstan-drupal: ^0.12.11. Closed that as a duplicate, even though the reason is not the same, the patch would be the same as the first hunk here. Transporting the credits here.

Thanks all!

Woo!