Steps to reproduce

  1. Make sure one of the admin themes is turned on (either Claro or Seven), but that the other admin theme is uninstalled.
  2. Install the other admin theme of your choosing. There will be a success and/or warning message that the theme was installed
  3. Inspecting the status HTML, you should find it coded as: <div role="contentinfo" aria-label="Status message" class="messages messages--status">...<div>. This is true for both success and warning.

    4. Ways to Fix

    Since the footer element maps to a contentinfo, using this role for statuses doesn't make sense and should be changed to <div role="status" aria-label="Status message" class="messages messages--status">...<div>, or <div aria-live="polite" aria-atomic="true" aria-label="Status message" class="messages messages--status">...<div> if there are concerns about backwards compatibility.

    Choosing the Claro theme since that's a top priority, but this does occur in the Seven admin theme as well.

CommentFileSizeAuthor
#15 3159933-15.patch13.98 KByogeshmpawar
#14 Patch 3159933 Fail.png1 MBchetanbharambe
#11 3159933-patch_applied.png97.64 KBabhijith s
#9 interdiff-5-9.txt832 byteshardik_patel_12
#9 3159933-9.patch14.75 KBhardik_patel_12
#5 3159933-5.patch13.78 KBspiritcapsule
Screen Shot 2020-07-17 at 10.53.14 AM.png236.66 KBcarlygerard

Issue fork drupal-3159933

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

CarlyGerard created an issue. See original summary.

carlygerard’s picture

carlygerard
She/Her/Hers
commented
Issue summary: View changes
carlygerard’s picture

carlygerard
She/Her/Hers
commented
Issue summary: View changes
carlygerard’s picture

carlygerard
She/Her/Hers
commented
Issue summary: View changes
spiritcapsule’s picture

spiritcapsule commented
Status: Active » Needs review
StatusFileSize
new 3159933-5.patch13.78 KB

ok first attempt at this one. I wasn't sure whether to include the changes for all of the core themes in addition to the main template in the system module. I included them figuring it would be easy to remove them if needed.

spiritcapsule’s picture

spiritcapsule commented

this issue seems like a duplicate of https://www.drupal.org/project/drupal/issues/2942404, but I didn't realize that until after I had submitted the patch here

Status: Needs review » Needs work

The last submitted patch, 5: 3159933-5.patch, failed testing. View results

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Component: Claro theme » markup

Moving this to the markup component since the bug isn't specific to Claro.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3159933-9.patch14.75 KB
new interdiff-5-9.txt832 bytes

Solving failed test case.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3159933-patch_applied.png97.64 KB

Patch #9 can't be applied on 9.2.x

after

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented

Crosslinking, there is definitely an effort duplication between this issue and #2942404: System messages should be accessible.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Needs work
StatusFileSize
new Patch 3159933 Fail.png1 MB

Hi @Hardik_Patel_12

Above Patch #9 is getting failed.
Can you please check it once again and attach some before and after screenshots.

Please refer attached screenshots for the same.
Needs to be re-rolled for 9.3.x
Can be a move to Needs work.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 3159933-15.patch13.98 KB

Straight re-roll against 9.3.x

Status: Needs review » Needs work

The last submitted patch, 15: 3159933-15.patch, failed testing. View results

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

swirt’s picture

swirt
he/him
Primary language English
commented

Patch #15 fails to apply to drupal/core (9.5.2)

Cannot apply patch 3159933 - Contentinfo landmark (https://www.drupal.org/files/issues/2021-10-26/3159933-15.patch)!

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +wcag413

This shift makes sense to me based on https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA22

Marking this as SC 4.1.3 https://www.w3.org/WAI/WCAG21/Understanding/status-messages

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.