In Drupal 9.0.2 works Blazy, works Photoswipe, but Blazy PhotoSwipe doesn't work :-/
My error:
Drupal\Core\Security\UntrustedCallbackException: Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was blazy_photoswipe_pre_render. See https://www.drupal.org/node/2966725 v Drupal\Core\Render\Renderer->doTrustedCallback() (line 96 file /DRUPAL/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php).
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | blazyPhotoswipe-0003.png | 1.22 MB | sergiy bovdyr |
| #14 | blazyPhotoswipe-0002.png | 683.8 KB | sergiy bovdyr |
| #14 | blazyPhotoswipe-0001.png | 55.76 KB | sergiy bovdyr |
Comments
Comment #2
sakonn commentedConfirming the issue on drupal 9.0.5.
Comment #3
sakonn commentedConfirming the issue on drupal 9.0.5.
Comment #4
sakonn commentedI have created a patch for this error.
It creates BlazyPhotoswipe class which implements TrustedCallbackInterface.
Then is used this new method for pre_rendering.
Comment #5
mandus.cz commentedThanks for the patch. It works.
Comment #6
timlie commentedCan also confirm this patch works.
Comment #7
skinThanks, the patch from Comment #4 works for me
Comment #8
extect commented+1 for #4. Solves the issue on D9! Thank you!
Would be great to get this committed soon.
Setting to critical since this issue ends in a WSOD.
Comment #9
gausarts commentedSorry for delay. Hope you are doing well.
This was fixed in DEV and the patch won't apply to DEV branch. I changed and avoided that callback for Drupal 8.7 (lower versions) compatibility:
https://git.drupalcode.org/project/blazy_photoswipe/-/blob/8.x-1.x/blazy...
Hence that is why I set it back to Normal due to Drupal 8.7 compat as otherwise the same WSOD hits 8.7 lower.
Could anyone test the DEV branch so I can release a new branch? I don't have Drupal dev handy now to re-check the DEV branch.
Be sure to clear cache due to this patch or newly introduce function in DEV.
Comment #10
gausarts commentedSorry in case you misunderstood. Don't apply this patch, use the DEV as is, and please report. Thanks.
Comment #11
extect commentedSorry, I didn't even know there is a dev release since it is not linked from the modules homepage. However, I can confirm DEV is working nicely on D9, even without the patch.
Since this is causing major issues when not using dev, is there any chance to get a new release oder open a new branch for Drupal >8.7 ?
Comment #12
gausarts commented@sakonn, the DEV branch already took different direction since Jun last year:
https://www.drupal.org/commitlog/commit/90628/fda49022c4ac30a713131dbf28...
And I cannot revert it to yours, sorry. Appreciated regardless.
Again sorry for delay. Thanks for patience, guys. Have a good day.
Committed.
Comment #14
sergiy bovdyr commentedHello everyone!
I don’t know if I’m writing in the right place, but I think so, because with this module it became possible to use the PhotoSwipe module in the Slick gallery. After the last update on 17-04-2021 of the Slick module and its submodules, the images in the popup are not displayed in their original form, the size is distorted. Before that, everything worked great. Unfortunately, I don't know how to fix this yet.
Comment #15
sergiy bovdyr commentedHello everyone!
I don’t know if I’m writing in the right place, but I think so, because with this module it became possible to use the PhotoSwipe module in the Slick gallery. After the last update on 17-04-2021 of the Slick module and its submodules, the images in the popup are not displayed in their original form, the size is distorted. Before that, everything worked great. Unfortunately, I don't know how to fix this yet.
Comment #16
gausarts commented@Sergiy Bovdyr, please check out solutions here:
https://www.drupal.org/project/blazy_photoswipe/issues/3179924#comment-1...
This thread has nothing to do with your display issue.
Comment #17
sergiy bovdyr commented@Gausarts thanks a lot for the link! I will try again.