Problem/Motivation

The DraggableViews::getIndex() function is limited to nodes and media items by the hardcoded id names. This is a problem for other entities such as Commerce Products.

Proposed resolution

Use the generic entity id() function instead.

CommentFileSizeAuthor
#7 draggableviews-use_id_function-3158196-7.patch764 bytesergonlogic
#2 3158196-use-id-function.patch761 bytesdaniel korte

Issue fork draggableviews-3158196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Daniel Korte created an issue. See original summary.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Assigned: daniel korte » Unassigned
Status: Active » Needs review
StatusFileSize
new 3158196-use-id-function.patch761 bytes

guillaumepacilly made their first commit to this issue’s fork.

guillaumepacilly opened merge request !43

istryker’s picture

istryker commented
Status: Needs review » Closed (duplicate)

I don't believe we should be calling the _entity function. #2985291: Support identifiers other than nid (whatever the base entity of the view is) solution is better. Closing as duplicate.

istryker closed merge request !43

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Version: 2.0.x-dev » 2.1.4
StatusFileSize
new draggableviews-use_id_function-3158196-7.patch764 bytes

I know it's bad form to comment on closed issues. However, this issue still affects the current release.

So, here's a re-rolled patch for 2.1.4, pending a release that incorporates #2985291: Support identifiers other than nid (whatever the base entity of the view is)