Drupal 8.9.2 upgrade by drush overwrites key files [#3158116]

8.9.1 to 8.9.2 upgrade trashes the site

drush up - performs the 8.9.2 upgrade but completely replaces the "vendor" directory - deleting existing needed 3rd party config directories and overwrites composer.json completely also breaking the site.

Status report will not load and Commerce config page are both broken to a 500 error "not working" page - in part because the upgrade deleted the commerce stripe libraries in the vendor directory among what would be other things

On the D7 site - still running thank god - this same command works fine

Copying the /root/drushbackup files back to the location brings the old site back up

Not good

Comments

Comment #1

9 July 2020 at 17:57

bobburns created an issue. See original summary.

Comment #2

cilefen commented 9 July 2020 at 22:09

Category:

Bug report

» Support request

It looks like this has been answered: https://drupal.stackexchange.com/questions/256441/drupal-8-update-via-dr...

Comment #3

bobburns commented 10 July 2020 at 03:05

That is something that should be prominently mentioned on the download page at Drupal.org

For people upgrading from Drupal 7 - a lot of people will fall into that hole of mixing install methods - especially when Drupal 8 does not let you install any other way but Composer for it to work, and then there is the issue that automatic updates for someone developing module ode land patching loosing code that way.

Now all the site does is "The website encountered an unexpected error. Please try again later." from any menu item and I cannot even get into the log to see what it is

Upon running install.php it threw the exception into the browser and I was then able to deconstruct the problem and fix it by a manual downgrade

Comment #4

cilefen commented 10 July 2020 at 01:43

The download page links to documentation such as https://www.drupal.org/docs/updating-drupal and the Drupal download contains core/UPDATE.txt. Both of these describe the proper update process.

If there is something else you think would help we could move this to another queue for Drupal.org content.

Comment #5

bobburns commented 10 July 2020 at 15:35

I am talking about a great big warning like the link you provided clearly says about mixing install methods and how drush will destroy the vendor directory with an over-write. I have been using drupal for ten years and this is a major enough change it should be a huge warning focus and it is no mentioned anywhere in the docs instead it appears the options are business as usual

Here is another issue from https://www.drupal.org/project/commerce/issues/3027026 where until you are faced with the error and a broken site - you would not know the answer.

bojanz writes at number 4

""Using Drush for module downloads or core updates is the source of fragility here.

Commerce can only be installed via Composer.
Once you start using Composer, you must use it to update core.
Using Drush to update core will break your site like in this example, because it will overwrite the vendor folder.""

since this is an issue of requiring Composer - as I am dev eloping - I have to now be sure and "#" out the project name in the info file to keep from loosing patches and code I have worked on.

A REALLY BIG stop sign needs to be prominently placed and the docs need to be modified to remove or have that STOP SIGN in the docs at manual update and drush as options that actualkly really do not work es[ecially desp[ending on the projects one has installed.

and then they should be referrred to https://www.drupal.org/docs/updating-drupal/update-drupal-core-via-composer and https://www.drupal.org/forum/support/upgrading-drupal/2020-07-09/upgradi... as to how to do it.