Taxonomy tag too big. Not responsive in mobile devices.

CommentFileSizeAuthor
#9 Screenshot 1942-07-02 at 5.44.58 PM.png191.82 KBgauravvvv
#9 overflow-wrap-3157432-9.patch722 bytesgauravvvv
#6 taxonomy-tag-issue-fixed-6.patch328 bytesgauravvvv
#4 taxonomy-tag-issue-fixed-3.patch328 bytesgauravvvv
#2 taxonomy-tag-issue-fixed-3157432-2.patch0 bytesgauravvvv
Screenshot (300).png11.34 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new taxonomy-tag-issue-fixed-3157432-2.patch0 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
Title: Link tag too big » taxonomy tag link too big.
Status: Active » Needs review
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new taxonomy-tag-issue-fixed-3.patch328 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new taxonomy-tag-issue-fixed-6.patch328 bytes

I have provided the patch please verify if it is working or not.

sim_1’s picture

sim_1
she/her
commented
Status: Needs review » Postponed

Hi @Gauravmahlawat, thank you for writing up this issue and creating a patch.

I agree that non-breaking text doesn't look good. But I'm not sure if it makes sense for us hard-code in styles that aren't: a) used in base core themes or b) directly related to styles that Zurb Foundation offers. Especially since we'd be assuming this is the behavior people want for all .field-item a links.

I'm 100% open to other opinions! I'm just a little wary of adding CSS that would have to be overwritten in sub-themes.

gauravvvv’s picture

gauravvvv commented

@sim_1 Yes, I agree this is not the correct way to add .field-item a, but we can do global styling by applying CSS properties on link tags, If we are showing a link to the user then it should be shown fully. That was the main reason I made this an issue.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new overflow-wrap-3157432-9.patch722 bytes
new Screenshot 1942-07-02 at 5.44.58 PM.png191.82 KB

Hello @sim_1 that was not a correct way to avoid overflow, but we can use body {overflow-wrap: break-word;}. Here I have provided a patch please review if it is working or not. Additionally adding a after patch screenshot for reference.

gauravvvv’s picture

gauravvvv commented
Status: Postponed » Needs review
sim_1’s picture

sim_1
she/her
commented
Status: Needs review » Closed (won't fix)

Thank you for your work on this, but I am marking this as closed and won't fix for now. My reasoning is that this is default behavior for CSS, and not an issue caused by the Foundation theme.