Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2020 at 04:15 UTC
Updated:
26 Oct 2020 at 05:39 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoComment #3
avpadernoThank you for applying! Remember to change status, as in this issue queue, Active is used when the project is not jet ready to be reviewed. When the project is ready to be reviewed, the status should be set to Needs review.
Comment #4
robert.duplock commentedComment #5
sadashiv commentedI tried to review this and the module does what it says:
1) Without the module installed the layout page for book content type admin/structure/types/manage/book/display/default/layout showed frontend theme and with the module enabled it showed admin theme
2) Also the configuration works fine i.e. turning off in admin menu shows the frontend theme again.
3) PHPCS shows no errors, etc.
4) README looks good.
I think it's all good.
Thanks,
Sadashiv
Comment #6
shaktiklooks good to me, PHPCS shows no errors.
Comment #7
harishh commentedNo errors found and also maintained the Drupal standards.
Comment #8
phthlaap commentedPlease capitalize the name of the module and dependency namespacing in .info.yml file
Link to follow: https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Comment #10
avpadernoThe task of reviewers is pointing out what needs to be changed, not providing patches. We don't review patches, and the status is changed only when the user who is applying commits the changes in the project repository, or the described changes are wrong.
Comment #11
robert.duplock commentedPlease see Release Candidate 3 with capitalised spelling of the module's name.
- https://www.drupal.org/project/layout_builder_admin_theme/releases/8.x-1...
- https://git.drupalcode.org/project/layout_builder_admin_theme
Comment #12
5droid commentedIf I am using Drupal 7 for my website. Do I need to upgrade to Drupal 8 or 9?
Comment #13
avpaderno@5droid This is not the place to ask for support. It's the review queue for users who want to get the vetted role.
Comment #14
avpadernoI am changing priority as per https://www.drupal.org/node/539608.
Comment #15
phthlaap commentedThanks for your application, I don't see any security issue related into the code.
Comment #16
klausiReviewed the module, all looking good to me.
Thanks for your contribution, Rob!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #17
klausiAssigning credits.
Comment #18
robert.duplock commentedMany thanks to everyone who took the time to help with this security coverage application.