Problem/Motivation
https://www.drupal.org/node/3018145
The sync directory is defined in $settings and not $config_directories
Proposed resolution
Could we scan settings.php for this? Would this be a drupal-rector thing?
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2021-07-19 at 15.07.35.png | 84.79 KB | gábor hojtsy |
| #4 | 3154341.patch | 1.3 KB | gábor hojtsy |
Comments
Comment #2
gábor hojtsyWe could test this in our environment check.
Comment #3
gábor hojtsyMoving to current branch.
Comment #4
gábor hojtsyMade this my first trial issue of drupalpod. Created and tested / generated patch there. Drupalpod / ddev has fallback code for older Drupal versions, so will notify about this config.
Comment #5
gábor hojtsyComment #7
gábor hojtsyCommitted. We don't have tests for environment checks since that would require to somehow change the environment.
Comment #8
gábor hojtsyUnfortunately I needed to roll this back in #3224551: Warning about $config_directories deprecation will never get resolved, roll it back since it was not possible to resolve ever. Opened #3224660: The Drupal 8 to 9 $config_directories deprecation is not detected to try to get this resolved again (and have a clean slate in terms of commits). Will carry over credits for @tedbow.