Closed (fixed)
Project:
Olivero
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
19 Jun 2020 at 16:39 UTC
Updated:
27 Aug 2020 at 13:44 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
Homotechsual commentedComment #3
anruetherComment #4
anruetherIs this a dub of the related issue?
Comment #5
Homotechsual commentedThe other issue relates to headings. This issue is about the tab-titles which are still ALL CAPS :-)
Comment #6
pradeepjha commentedWe might need designer consideration here. I've tried locally by removing CAPS from the tab links. This is how it looks:
Also we can compare with Seven theme:
Comment #7
andrewmacpherson commented#6 looks fine to me. I don't know what useful purpose uppercase would serve there.
There are other instances of uppercase text which I think are unwarranted. In particular, I'd say these instances are particularly risky:
Fieldset legends and table headers are completely arbitrary text, and there's no telling how long they may be, or what they will say.
Comment #8
mherchelBlock headings are also all-caps. Is this okay in this context or no?
Comment #9
karing[#d9-theme meeting] -> if you like we can put a patch up removing all text-transform: uppercase - or do you think this requires more thought/discussion?
Comment #10
andrewmacpherson commentedBlock titles are in the same league as the other ones seen here; they have an arbitrary content and length.
The problem of all-caps for readability is well attested (regardless of dyslexia), and many style guides caution against their use. The frustrating part is that most of them are rather vague about it. They typically advise you to "avoid overuse", or "use sparingly", without any useful advice on how to assess this. Some suggest that uppercase is OK for "short titles", again with no guidance on what that amounts to. I wrote more about this in #2958239-8: Readability problem with all-caps text in core themes.
Of all the style guides that I've read, there's only one which provides a clear process. The Web Style Guide (3rd edition) is all-out against it. "Capitalized text is one of the most common and least effective methods for adding typographical emphasis. [...] We recommend down-style typing (capitalize only the first word and any proper nouns) for your headlines, subheads, and text."
WCAG 2.0 doesn't say much about it, but there is a tantalizing placeholder for an advisory technique in Understanding SC 1.4.8 Visual Presentation which says: "Using upper and lower case according to the spelling conventions of the text language (future link)". Presumably the proposed technique never gained consensus; it isn't mentioned from the WCAG 2.1 version. That doesn't mean it isn't good advice; more likely it was dropped because it wasn't deemed to be sufficiently testable. So it's no better than those style guides.
As I see it, the main problems with using all-caps are:
Brute-forcing all-caps via CSS isn't taking any of these contexts into account. So my view is coming around to an outright ban on using
text-transform: uppercasefor a theme which needs to be as general-purpose as Olivero. (Meaning any core, contrib, or distro theme really.)Comment #11
andrewmacpherson commented@anruether - thanks for linking to #2958239: Readability problem with all-caps text in core themes, and making it the parent issue here.
For anyone interested in the topic, that issue has much more information and discussion.
@KarinG - going ahead with the patch would be a good idea. At the very least, it's a survey of all the places that are using it, and we can get a better picture of whether those places will need any further design changes.
Comment #12
karingComment #13
karingFound 20 uses:
karins-MBP:olivero sysadmin$ git diff |grep uppercase |wc -l
20
In addition to the places already referenced -> also in user account menu e.g.
Patch -> attached()
Comment #14
karingComment #15
steinmb commentedNot sure if you where asking for reviews?
Patch apply cleanly.
Before
After
Comment #16
karingThanks for confirming and toggling to Needs review.
In last week's (or was it the week before that...) Slack meeting when I asked about it @mherchel mentioned that this change was with the designers for their input/review.
Comment #17
mherchelUpdated designs without all caps are at https://www.figma.com/file/r8uq72Q9weTMVsNUFZKEYH/D9-Theme-Master?node-i...
Comment #18
karingSorry not understanding what the work to be done is? The patch is already transforming everything to lower case - or are you saying it just needs to be rebased to latest -dev?
Comment #19
mherchelI believe there are some type size, spacing, and weight changes. I guess the first step is to inventory exactly what needs to be changed.
Comment #20
karingI don't think I know enough about figma (first look ever just now) - to extract/spot that detail. Sorry about that!
Comment #21
mherchelThis patch makes the changes in Figma, and includes adding the semibold variant of the Metropolis font.
Comment #22
karingAwesome! 👍
Happy to pull that in and test it tomorrow!
Comment #23
karingReviewing this now!
git pull
patch applies cleanly:
Clear all caches
Visual check - great! Looked at menu items, tabs, table headers, block titles, button (managed to get them into one screenshot):

Comment #24
mherchelYay!
I'm going to commit this now (I want to tag a release today).
Comment #26
mherchelCommitted!