Closed (fixed)
Project:
Olivero
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Jan 2020 at 18:22 UTC
Updated:
13 Apr 2020 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andrewmacpherson commentedI agree. Headings are an arbitrary length, and will often be as long as an entire sentence. All-caps will make it harder to read, and users with dyslexia more severely.
Adding a related issue which discusses the the problem in existing core themes. It has lots more links to various style guides and articles which take a dim view of all-caps.
Comment #3
ellenoiseThis issue would be very easy to fix. In `src/css/components/main.css`, remove Line 38: `text-transform: uppercase;`. Here's what the headings look like when the H2 uppercase styling is removed:
Comment #4
proeungI'd like to get @jwitkowski79's input on this as well. What do you think about dropping all the uppercase for the H2 heading?
Comment #5
jwitkowski79 commented@proeung: I think we're okay dropping the uppercase for H2. I just did a small test on what this would look like and there's enough of a difference in the font size and weight that it still reads as an H2
Comment #6
jwitkowski79 commentedComment #7
andrewmacpherson commentedThat's a nice outcome then. Let's go for it.
Comment #8
thejimbirch commentedPatch attached that removes text-transform: uppercase on H2s.
Comment #9
mherchel@thejimbirch can you re-roll this? Note you'll need to attach both the src (in
css/src/) and distribution (incss/dist/).Comment #10
kostyashupenkoComment #11
mherchelCommitted!